Print the key name when max_length is exceeded #43061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @o-nikolas re our discussions with long task_id and MySQL. |
|
Can you please fix the unit test @jabbera ? |
Thanks @potiuk! Looking 👀 |
potiuk
approved these changes
Oct 17, 2024
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
* Print the key name when max_length is exceeded * Fix tests
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
* Print the key name when max_length is exceeded * Fix tests
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
* Print the key name when max_length is exceeded * Fix tests
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* Print the key name when max_length is exceeded * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had the ambiguous error show up in our logs: airflow.exceptions.AirflowException: The key has to be less than 250 characters. We had a task_id >= 250 characters and it was because of long task group names and some nesting. The log message was not helpful in pointing out where the error was. Adding the key value to the exception was super helpful diagnosing where the issue was.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.