Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error: AttributeError: 'bool' object has no attribute 'lower' by:… #42771

Conversation

navamongkolabacusdigital

since I found the problem when using MongoDB To Amazon S3 transfer operator

Then, connection provider with MongoDB give me fix extra values

{
"srv": false,
"ssl": false,
"allow_insecure": false
}

Which all the values string. But the part of checking if allow_insecure is to receive string and .lower()

The error looks likes:

File "/home/airflow/.local/lib/python3.12/site-packages/airflow/providers/mongo/hooks/mongo.py", line 139, in __init__
    self.allow_insecure = self.extras.pop("allow_insecure", "false").lower() == "true"
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'bool' object has no attribute 'lower'

If there are other solutions, I am happy for the contribution

ref: https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/transfer/mongo_to_s3.html

… provider mongo hooks allow key type boolean
Copy link

boring-cyborg bot commented Oct 5, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@romsharon98
Copy link
Contributor

Your solution will work.
I think better solution will be to change the connection to get allow_insecure as a property and not in extra and it will be with type bool and default False.

@topherinternational
Copy link
Contributor

This problem definitely needed to be fixed, but I think this got covered by #42930/#43024.

@eladkal
Copy link
Contributor

eladkal commented Nov 11, 2024

Closing as suppressed by #42930 and #43024.

@eladkal eladkal closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants