-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to switch between table and card views for listing items #42711
Conversation
d47ae6b
to
ba258e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I just have some nitty suggestions—feel free to ignore.
Have you considered taking this opportunity to switch to single quotes (''
) instead of double (""
)? I think the former is more common. I definitely find it easier to read.
Oh nooo - all application UIs who call themself modern introduce card layouts... and I never understood what the benefit of this would be especially if you don't have thumbnails (e.g. like an image gallery) - So the new UI is now on the same level? Do we really "need" a card layout? I would have imagined we have more basic critical features to be added first :-D |
How about ... Peoople love it and feel they are using something modern? That's a very good reason. 😛 |
Yeah that might be :-D Welcome CardLayout! (I hope it is of any use :-D besides feeling modern) |
There will be quite a lot of tables in the Airflow UI. I consider this foundational UI work to make a good component for us to reuse everywhere. For complex objects, a customize card view can display all the information better than having to horizontally scroll for a dozen+ columns. While we have a lot of API work to do. I wanted to flesh out the UI more too, to test out all our styling rules and give other contributors more examples to refer to. |
b4d4171
to
024a9b3
Compare
c5fd91e
to
0df9cb7
Compare
557e009
to
8e0081c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected, code looks good :)
…pache#42711) * Add ability to switch between table and card views for listing items * add test for DagCard and loading states * Add tests for loading states * PR feedback * use semantic tokens for reused colors * Remove eslint-ignore lost in rebase
…pache#42711) * Add ability to switch between table and card views for listing items * add test for DagCard and loading states * Add tests for loading states * PR feedback * use semantic tokens for reused colors * Remove eslint-ignore lost in rebase
…pache#42711) * Add ability to switch between table and card views for listing items * add test for DagCard and loading states * Add tests for loading states * PR feedback * use semantic tokens for reused colors * Remove eslint-ignore lost in rebase
…pache#42711) * Add ability to switch between table and card views for listing items * add test for DagCard and loading states * Add tests for loading states * PR feedback * use semantic tokens for reused colors * Remove eslint-ignore lost in rebase
Add a card list component to oru shared table component to allow toggling between a regular table view or a card list.
Closes #42698 and #42734
Also, added loading states:


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.