FIX: Only pass connection to sqlalchemy engine in JdbcHook #42705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne in JdbcHook, don't generalize it.
emredjan
reviewed
Oct 3, 2024
2 tasks
dabla
changed the title
shahar1
reviewed
Oct 3, 2024
This reverts commit 05714bc.
…method and return a mocked connection
shahar1
approved these changes
Oct 4, 2024
potiuk
approved these changes
Oct 7, 2024
96 tasks
kunaljubce
pushed a commit
to kunaljubce/airflow
that referenced
this pull request
Oct 13, 2024
) * refactor: Only pass connection as creator to create a sqlalchemy engine in JdbcHook, don't generalize it. * refactor: Make sure engine_kwargs is initialised * docs: Fixed type in docstring * Revert "docs: Fixed type in docstring" This reverts commit 05714bc. * refactor: Added unit test for get_sqlalchemy_engine in JdbcHook * refactor: Reformatted get_hook method in TestJdbcHook * refactor: Refactored get_hook method in TestJdbcHook * refactor: Subclassed JdbcHook to allow overriding the get_connection method and return a mocked connection --------- Co-authored-by: David Blain <david.blain@infrabel.be>
This was referenced Oct 18, 2024
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
) * refactor: Only pass connection as creator to create a sqlalchemy engine in JdbcHook, don't generalize it. * refactor: Make sure engine_kwargs is initialised * docs: Fixed type in docstring * Revert "docs: Fixed type in docstring" This reverts commit 05714bc. * refactor: Added unit test for get_sqlalchemy_engine in JdbcHook * refactor: Reformatted get_hook method in TestJdbcHook * refactor: Refactored get_hook method in TestJdbcHook * refactor: Subclassed JdbcHook to allow overriding the get_connection method and return a mocked connection --------- Co-authored-by: David Blain <david.blain@infrabel.be>
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
) * refactor: Only pass connection as creator to create a sqlalchemy engine in JdbcHook, don't generalize it. * refactor: Make sure engine_kwargs is initialised * docs: Fixed type in docstring * Revert "docs: Fixed type in docstring" This reverts commit 05714bc. * refactor: Added unit test for get_sqlalchemy_engine in JdbcHook * refactor: Reformatted get_hook method in TestJdbcHook * refactor: Refactored get_hook method in TestJdbcHook * refactor: Subclassed JdbcHook to allow overriding the get_connection method and return a mocked connection --------- Co-authored-by: David Blain <david.blain@infrabel.be>
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
) * refactor: Only pass connection as creator to create a sqlalchemy engine in JdbcHook, don't generalize it. * refactor: Make sure engine_kwargs is initialised * docs: Fixed type in docstring * Revert "docs: Fixed type in docstring" This reverts commit 05714bc. * refactor: Added unit test for get_sqlalchemy_engine in JdbcHook * refactor: Reformatted get_hook method in TestJdbcHook * refactor: Refactored get_hook method in TestJdbcHook * refactor: Subclassed JdbcHook to allow overriding the get_connection method and return a mocked connection --------- Co-authored-by: David Blain <david.blain@infrabel.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue 42644, the connection should only be passed to create the sqlalchemy engine for the JdbcHook, and not in a generic way in the DbApiHook, so that mixed usage of sqlalchemy engine and database connections is still possible (e.g. odbc with pymssql for example).
closes: #42664
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.