Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for Google provider's system tests #42614

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

VladaZakharova
Copy link
Contributor

This PR removes prefix 'example_' from DAG name to follow name convention, adds comments and define 'default' ENV_ID if not provided.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers area:system-tests provider:google Google (including GCP) related issues labels Oct 1, 2024
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the comment from @romsharon98

Copy link
Contributor

@romsharon98 romsharon98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me also, just let me know if you want to fix my comment or not (it depends on you) and will merge it

@potiuk potiuk merged commit a82a4e7 into apache:main Oct 3, 2024
56 checks passed
joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
Co-authored-by: Ulada Zakharava <vlada_zakharava@epam.com>
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Co-authored-by: Ulada Zakharava <vlada_zakharava@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers area:system-tests provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants