Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make migrations path relative to ini #42381

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Make migrations path relative to ini #42381

merged 1 commit into from
Sep 20, 2024

Conversation

dstandish
Copy link
Contributor

This makes it so that we can alembic commands from the root repo dir.

E.g.

alembic -c airflow/alembic.ini revision --autogenerate -m "Do something"

Sometimes when running from airflow subfolder we get errors.

@dstandish
Make migrations path relative to ini
88eb39a 
This makes it so that we can alembic commands from the root repo dir.

E.g.

```
alembic -c airflow/alembic.ini revision --autogenerate -m "Do something"
```

Sometimes when running from airflow subfolder we get errors.
@ephraimbuddy
Copy link
Contributor

I had instructed contributors to copy the airflow’s alembic.ini here https://github.com/apache/airflow/blob/main/contributing-docs/13_metadata_database_updates.rst#create-alembic-migration-scripts. Maybe we should also update there

@dstandish
Copy link
Contributor Author

I had instructed contributors to copy the airflow’s alembic.ini here https://github.com/apache/airflow/blob/main/contributing-docs/13_metadata_database_updates.rst#create-alembic-migration-scripts. Maybe we should also update there

I don't really understand the implications re what that section is about and how this would impact that. Can you possibly make a suggestion re what I should change?

@ephraimbuddy
Copy link
Contributor

https://github.com/apache/airflow/blob/main/contributing-docs/13_metadata_database_updates.rst#create-alembic-migration-scripts

This line in the doc:
Replace the content of your application's alembic.ini file with Airflow's alembic.ini copy..

I'm not sure it will work if copied over. WDYT?

ephraimbuddy
ephraimbuddy approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@ephraimbuddy ephraimbuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works

@ephraimbuddy
Copy link
Contributor

We can also update the one at airflow/providers/fab/alembic.ini

@ephraimbuddy ephraimbuddy merged commit 5ed3f49 into apache:main Sep 20, 2024
51 checks passed
@ephraimbuddy ephraimbuddy deleted the make-migratinos-path-relative-to-ini branch September 20, 2024 18:10
@dstandish
Copy link
Contributor Author

Tested and it works

Thanks a bunch Ephraim 🙏

joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
@dstandish @joaopamaral
Make migrations path relative to ini (apache#42381)
557a549 
This makes it so that we can alembic commands from the root repo dir.

E.g.

```
alembic -c airflow/alembic.ini revision --autogenerate -m "Do something"
```

Sometimes when running from airflow subfolder we get errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ephraimbuddy ephraimbuddy ephraimbuddy approved these changes

@jedcunningham jedcunningham Awaiting requested review from jedcunningham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstandish @ephraimbuddy