Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate AutoMLBatchPredictOperator and refactor AutoML system tests #42260

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

olegkachur-e
Copy link
Contributor

  • Remove example_automl_model.py as obsolete.
  • Move example hooks to example_automl_translation.py
  • Update documentation
  • Deprecate AutoMLPredictBatchOperator completely, as it cannot be used with translation model, previous usage has been already deprecated.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@eladkal eladkal requested a review from shahar1 September 19, 2024 03:22
@shahar1 shahar1 changed the title Refactor google provider AutoML system tests Deprecate AutoMLBatchPredictOperator and refactor AutoML system tests Sep 19, 2024
Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-commits and tests fail.
In general, I'd separate it into 2 PRs - one for deprecation and one for the refactoring.
Not too critical for now though, but please think about it in the next times ("single-responsibility PRs" make them easier for reviewing).

@olegkachur-e olegkachur-e force-pushed the refactor/automl_tests branch 2 times, most recently from 845b6d4 to 0abad9f Compare September 23, 2024 22:31
- Remove example_automl_model.py as obsolete.
- Move example hooks to example_automl_translation.py
- Update documentation
- Deprecate AutoMLPredictBatchOperator completely, as it cannot be used with
  translation model, previous usage has been already deprecated.
@shahar1 shahar1 merged commit 56ab422 into apache:main Sep 27, 2024
56 checks passed
joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
…apache#42260)

- Remove example_automl_model.py as obsolete.
- Move example hooks to example_automl_translation.py
- Update documentation
- Deprecate AutoMLPredictBatchOperator completely, as it cannot be used with
  translation model, previous usage has been already deprecated.

Co-authored-by: Oleg Kachur <kachur@google.com>
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
…apache#42260)

- Remove example_automl_model.py as obsolete.
- Move example hooks to example_automl_translation.py
- Update documentation
- Deprecate AutoMLPredictBatchOperator completely, as it cannot be used with
  translation model, previous usage has been already deprecated.

Co-authored-by: Oleg Kachur <kachur@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants