Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-2779] Add project versions to LICENSE #4177

Merged
merged 1 commit into from
Nov 12, 2018

Conversation

ashb
Copy link
Member

@ashb ashb commented Nov 12, 2018

Make sure you have checked all steps below.

Jira

Description

  • The Incubator PMC requested that we add version information to the
    license declarations to cope with the possibility of projects changing
    licenses on us in the future.

Where possible I have worked out the version we are actually using, but
where that hasn't been possible and the project is still on the same
license (they all were) I have taken the latest version as of right now

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes flake8

The Incubator PMC requested that we add version information to the
license declarations to cope with the possibility of projects changing
licenses on us in the future.

Where possible I have worked out the version we are actually using, but
where that hasn't been possible and the project is still on the same
license (they all were) I have taken the latest version as of right now

[ci-skip]
@ashb
Copy link
Member Author

ashb commented Nov 12, 2018

@bolkedebruin @kaxil @Fokko Could one of you PTAL? I think this is the last thing needed before I can make a v1.10.1 RC1

@ashb ashb force-pushed the add-version-to-license-file branch from dcd720f to c90959c Compare November 12, 2018 19:46
@Fokko
Copy link
Contributor

Fokko commented Nov 12, 2018

Few of the Javascript dependencies are minimal versions. How do we deal with more recent versions?

Eg. https://github.com/apache/incubator-airflow/blob/master/airflow/www_rbac/package.json#L59

@ashb
Copy link
Member Author

ashb commented Nov 12, 2018

Good question. I've been going off this short post on the incubator mailing list:

I checked the source tar with the git tag and the License files.
We need to specify the third party dependencies version as they may have
different License in different version.
Please fix it in next around release.

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashb

I'm fine with merging this one. Maybe drop a follow up question on the mailinglist?

@Fokko Fokko merged commit 34b310e into apache:master Nov 12, 2018
@ashb ashb deleted the add-version-to-license-file branch November 12, 2018 21:07
ashb added a commit that referenced this pull request Nov 12, 2018
The Incubator PMC requested that we add version information to the
license declarations to cope with the possibility of projects changing
licenses on us in the future.

Where possible I have worked out the version we are actually using, but
where that hasn't been possible and the project is still on the same
license (they all were) I have taken the latest version as of right now

[ci-skip]
galak75 pushed a commit to VilledeMontreal/incubator-airflow that referenced this pull request Nov 23, 2018
The Incubator PMC requested that we add version information to the
license declarations to cope with the possibility of projects changing
licenses on us in the future.

Where possible I have worked out the version we are actually using, but
where that hasn't been possible and the project is still on the same
license (they all were) I have taken the latest version as of right now

[ci-skip]
tmiller-msft pushed a commit to cse-airflow/incubator-airflow that referenced this pull request Nov 27, 2018
The Incubator PMC requested that we add version information to the
license declarations to cope with the possibility of projects changing
licenses on us in the future.

Where possible I have worked out the version we are actually using, but
where that hasn't been possible and the project is still on the same
license (they all were) I have taken the latest version as of right now

[ci-skip]
elizabethhalper pushed a commit to cse-airflow/incubator-airflow that referenced this pull request Dec 7, 2018
The Incubator PMC requested that we add version information to the
license declarations to cope with the possibility of projects changing
licenses on us in the future.

Where possible I have worked out the version we are actually using, but
where that hasn't been possible and the project is still on the same
license (they all were) I have taken the latest version as of right now

[ci-skip]
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
The Incubator PMC requested that we add version information to the
license declarations to cope with the possibility of projects changing
licenses on us in the future.

Where possible I have worked out the version we are actually using, but
where that hasn't been possible and the project is still on the same
license (they all were) I have taken the latest version as of right now

[ci-skip]
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Jan 23, 2019
The Incubator PMC requested that we add version information to the
license declarations to cope with the possibility of projects changing
licenses on us in the future.

Where possible I have worked out the version we are actually using, but
where that hasn't been possible and the project is still on the same
license (they all were) I have taken the latest version as of right now

[ci-skip]
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
The Incubator PMC requested that we add version information to the
license declarations to cope with the possibility of projects changing
licenses on us in the future.

Where possible I have worked out the version we are actually using, but
where that hasn't been possible and the project is still on the same
license (they all were) I have taken the latest version as of right now

[ci-skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants