Fix overriden base container name not used to fetch logs on KPO trigger_reentry #40835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
|
Will fix static checks asap |
peloyeje
force-pushed
the
fix/base-container-name-on-trigger-reentry
branch
from
2557556 to
c45c093
Compare
|
Static checks fixed |
romsharon98
approved these changes
Jul 21, 2024
hussein-awala
approved these changes
Jul 22, 2024
| self.container_logs = container_logs | ||
| if self.container_logs == KubernetesPodOperator.BASE_CONTAINER_NAME: | ||
| self.container_logs = base_container_name or self.BASE_CONTAINER_NAME | ||
| self.base_container_name = base_container_name or self.BASE_CONTAINER_NAME |
There was a problem hiding this comment.
You can change the default value of base_container_name to BASE_CONTAINER_NAME and remove this line
There was a problem hiding this comment.
@peloyeje can you handle the above comment?
There was a problem hiding this comment.
Done, sorry for the delay.
Thanks for the review @hussein-awala!
peloyeje
force-pushed
the
fix/base-container-name-on-trigger-reentry
branch
from
ff79374 to
815c205
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that self.pod_manager.fetch_container_logs use instance-level self.base_container_name instead of BASE_CONTAINER_NAME.
Fixes log fetching when base container name is provided
Also attempts at simplifying the assignment logic for self.container_logs in the init
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.