Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIRFLOW-3238] Fix models.DAG.deactivate_unknown_dags #4073

Merged
merged 1 commit into from
Oct 21, 2018
Merged

[AIRFLOW-3238] Fix models.DAG.deactivate_unknown_dags #4073

merged 1 commit into from
Oct 21, 2018

Conversation

jason-udacity
Copy link
Contributor

@jason-udacity jason-udacity commented Oct 21, 2018 •
edited
Loading

Unknown dags are now deactivated on initdb

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes flake8

jason-udacity referenced this pull request Oct 21, 2018
@plypaul @aoen
[AIRFLOW-160] Parse DAG files through child processes
fdb7e94 
Instead of parsing the DAG definition files in the same process as the
scheduler, this change parses the files in a child process. This helps
to isolate the scheduler from bad user code.

Closes #1636 from plypaul/plypaul_schedule_by_file_rebase_master
@jason-udacity
[AIRFLOW-3238] Fix models.DAG.deactivate_unknown_dags
c94bbc6 
Unknown dags are now deactivated on initdb
@codecov-io
Copy link

codecov-io commented Oct 21, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@b156151). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4073   +/-   ##
=========================================
  Coverage          ?   77.71%           
=========================================
  Files             ?      199           
  Lines             ?    15958           
  Branches          ?        0           
=========================================
  Hits              ?    12402           
  Misses            ?     3556           
  Partials          ?        0
Impacted Files Coverage Δ
airflow/models.py 92.16% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b156151...c94bbc6. Read the comment docs.

@kaxil kaxil merged commit 39a9365 into apache:master Oct 21, 2018
kaxil pushed a commit that referenced this pull request Oct 21, 2018
@jason-udacity @kaxil
[AIRFLOW-3238] Fix models.DAG to deactivate unknown DAGs on initdb (#…
c2ae75c 
…4073)

Unknown dags are now deactivated on initdb
@kaxil kaxil requested a review from Fokko October 21, 2018 20:58
@ashb
Copy link
Member

ashb commented Oct 22, 2018

Does this also apply to upgradedb? I counsel people against running initdb in production (because it creates all the sample connections which is often not what people want.

ashb pushed a commit that referenced this pull request Oct 22, 2018
@jason-udacity @ashb
[AIRFLOW-3238] Fix models.DAG to deactivate unknown DAGs on initdb (#…
c1a1c1b 
…4073)

Unknown dags are now deactivated on initdb
ashb pushed a commit to ashb/airflow that referenced this pull request Oct 22, 2018
@jason-udacity @ashb
[AIRFLOW-3238] Fix models.DAG to deactivate unknown DAGs on initdb (a…
1eeb0a4 
…pache#4073)

Unknown dags are now deactivated on initdb
@jason-udacity
Copy link
Contributor Author

@ashb upgradedb does not invoke deactivate_unknown_dags as far as I'm aware.

@jason-udacity jason-udacity deleted the AIRFLOW-3238 branch October 22, 2018 20:15
tekn0ir pushed a commit to tekn0ir/incubator-airflow that referenced this pull request Oct 26, 2018
Merge branch 'master' into kubernetes
2b0f007 
* master:
  [AIRFLOW-520] Fix Version Info in Flask UI (apache#4072)
  [AIRFLOW-XXX] Add Neoway to companies list (apache#4081)
  [AIRFLOW-XXX] Add Surfline to companies list (apache#4079)
  Revert "[AIRFLOW-461] Restore parameter position for BQ run_load method (apache#4077)"
  [AIRFLOW-461] Restore parameter position for BQ run_load method (apache#4077)
  [AIRFLOW-461]  Support autodetected schemas in BigQuery run_load (apache#3880)
  [AIRFLOW-3238] Fix models.DAG to deactivate unknown DAGs on initdb (apache#4073)
  [AIRFLOW-3239] Fix test recovery further (apache#4074)
  [AIRFLOW-3203] Fix DockerOperator & some operator test (apache#4049)
  [AIRFLOW-1867] Add sandbox mode and py3k bug  (apache#2824)
  [AIRFLOW-2993] s3_to_sftp and sftp_to_s3 operators (apache#3828)
  [AIRFLOW-XXX] BigQuery Hook - Minor Refactoring (apache#4066)
  [AIRFLOW-3232] More readable GCF operator documentation (apache#4067)
galak75 pushed a commit to VilledeMontreal/incubator-airflow that referenced this pull request Nov 23, 2018
@jason-udacity @galak75
[AIRFLOW-3238] Fix models.DAG to deactivate unknown DAGs on initdb (a…
3b1d7e9 
…pache#4073)

Unknown dags are now deactivated on initdb
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
@jason-udacity
[AIRFLOW-3238] Fix models.DAG to deactivate unknown DAGs on initdb (a…
ed0108a 
…pache#4073)

Unknown dags are now deactivated on initdb
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Jan 23, 2019
@jason-udacity
Fix models.DAG to deactivate unknown DAGs on initdb (apache#4073)
5c2094b 
Unknown dags are now deactivated on initdb
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
@jason-udacity
[AIRFLOW-3238] Fix models.DAG to deactivate unknown DAGs on initdb (a…
ba87515 
…pache#4073)

Unknown dags are now deactivated on initdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fokko Fokko Awaiting requested review from Fokko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jason-udacity @codecov-io @ashb @kaxil