Don't pass auth to opensearch client with empty login and password #39982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cjames23 can you take a look? |
pdebelak
force-pushed
the
opensearch-handle-no-auth
branch
5 times, most recently
from
424cbd2 to
5f60395
Compare
pdebelak
force-pushed
the
opensearch-handle-no-auth
branch
from
5f60395 to
dd4badb
Compare
|
@eladkal @cjames23 is there any review action coming on this? My org could really use this change, we hit AWS OpenSearch with no auth (instead we validate that the client is inside our VPC/VPN). To get around the bug, we currently subclass the OpenSearchHook to shim in pretty much this exact code change. Would be great to not have to have this subclass at all. |
|
@eladkal ping again on reviewing this? cjames seems to be off the grid. |
Owen-CH-Leung
approved these changes
Oct 4, 2024
|
LGTM. This aligns with the Elasticsearch provider behaviour too |
This updates the opensearch hook to only pass the http_auth argument to the opensearch client if a login and password are part of the connection.
eladkal
force-pushed
the
opensearch-handle-no-auth
branch
from
3c9cc9f to
fc3732a
Compare
eladkal
approved these changes
Oct 4, 2024
96 tasks
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
* Don't pass auth to opensearch client with empty login and password This updates the opensearch hook to only pass the http_auth argument to the opensearch client if a login and password are part of the connection. * Add typed dict for opensearch client arguments to satisfy mypy
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* Don't pass auth to opensearch client with empty login and password This updates the opensearch hook to only pass the http_auth argument to the opensearch client if a login and password are part of the connection. * Add typed dict for opensearch client arguments to satisfy mypy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the opensearch hook to only pass the http_auth argument to the opensearch client if a login and password are part of the connection.
closes: #39979
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.