Fallback to locally installed k9s on ARM architecture #37371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very strange - inddeed looks like kind cluster is locally started on ARM, the emulation is disabled. The AMD k9s image runs fine (even if slow) when kind cluster is started, but it refuses to run with Very strange.... This PR workarounds it, but it would be nice to find out why . |
|
Closing. Known issue with Kind 0.21 kubernetes-sigs/kind#3510. We should rollback to 0.20 until it is solved. |
|
Actually #37373 did not help when reinstalled kind, and it seems this is a problem with system binfmt service that kubernetes-sigs/kind#3511 is going to fix it (looks like kind people are going to merge it and release new version soon), so we should wait for it and in the meantime have this one as a workaround. |
The docker image for k9s available from creator does not support ARM architecture so we used to use emulated version. Hoever recently for some reason when kind cluster is running, rosetta is disabled and the AMD images cannot be run. Therefore on MacOS / ARM we fallback to k9s locally installed (for example with brew).
potiuk
force-pushed
the
fallback-to-k9s-on-path-on-arm
branch
from
9229e5a to
9391675
Compare
potiuk
changed the title
Taragolis
reviewed
Feb 12, 2024
Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is>
Taragolis
approved these changes
Feb 13, 2024
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Feb 17, 2024
With kind 0.21.0 there was a bug that disallow to use emulation on ARM after creating Kind cluster, this has been fixed and new images were released so workaround we implemented in apache#37371 can be removed. However we should leave the option to use local k9s if installed by default, and switching to docker when `--use-docker` flas is used. We also add better diagnostics who might have pulled a buggy kindest image and telling them how to recover.
potiuk
added a commit
that referenced
this pull request
Feb 17, 2024
With kind 0.21.0 there was a bug that disallow to use emulation on ARM after creating Kind cluster, this has been fixed and new images were released so workaround we implemented in #37371 can be removed. However we should leave the option to use local k9s if installed by default, and switching to docker when `--use-docker` flas is used. We also add better diagnostics who might have pulled a buggy kindest image and telling them how to recover.
potiuk
added a commit
that referenced
this pull request
Feb 19, 2024
* Fallback to locally installed k8s on ARM architecture The docker image for k9s available from creator does not support ARM architecture so we used to use emulated version. Hoever recently for some reason when kind cluster is running, rosetta is disabled and the AMD images cannot be run. Therefore on MacOS / ARM we fallback to k9s locally installed (for example with brew). * Update dev/breeze/src/airflow_breeze/commands/kubernetes_commands.py Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is> --------- Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is> (cherry picked from commit 6754e9d)
potiuk
added a commit
that referenced
this pull request
Feb 19, 2024
With kind 0.21.0 there was a bug that disallow to use emulation on ARM after creating Kind cluster, this has been fixed and new images were released so workaround we implemented in #37371 can be removed. However we should leave the option to use local k9s if installed by default, and switching to docker when `--use-docker` flas is used. We also add better diagnostics who might have pulled a buggy kindest image and telling them how to recover. (cherry picked from commit f1af97a)
potiuk
added
the
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
* Fallback to locally installed k8s on ARM architecture The docker image for k9s available from creator does not support ARM architecture so we used to use emulated version. Hoever recently for some reason when kind cluster is running, rosetta is disabled and the AMD images cannot be run. Therefore on MacOS / ARM we fallback to k9s locally installed (for example with brew). * Update dev/breeze/src/airflow_breeze/commands/kubernetes_commands.py Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is> --------- Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is> (cherry picked from commit 6754e9d)
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
With kind 0.21.0 there was a bug that disallow to use emulation on ARM after creating Kind cluster, this has been fixed and new images were released so workaround we implemented in #37371 can be removed. However we should leave the option to use local k9s if installed by default, and switching to docker when `--use-docker` flas is used. We also add better diagnostics who might have pulled a buggy kindest image and telling them how to recover. (cherry picked from commit f1af97a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker image for k9s available from creator does not support ARM architecture so we used to use emulated version. Hoever recently for some reason when kind cluster is running, rosetta is disabled and the AMD images cannot be run. Therefore on MacOS / ARM we fallback to k9s locally installed (for example with brew).
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.