[AIRFLOW-1163] Add support for x-forwarded-* headers #3580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running Airflow behind a L7 proxy that sends x-fowarded-* headers, the Flask app miscontructs redirect URIs.
Codecov Report
@@ Coverage Diff @@
## master #3580 +/- ##
==========================================
+ Coverage 76.83% 76.83% +<.01%
==========================================
Files 204 204
Lines 15488 15492 +4
==========================================
+ Hits 11900 11904 +4
Misses 3588 3588
Continue to review full report at Codecov.
|
lxneng
pushed a commit
to lxneng/incubator-airflow
that referenced
this pull request
Aug 10, 2018
When running Airflow behind a L7 proxy that sends x-fowarded-* headers, the Flask app miscontructs redirect URIs. Closes apache#3580 from c4milo/master
|
Is there any info or context here on why this was closed without being merged? |
|
@drewblas, I believe this was merged using Git's CLI. |
|
Yeah, not merged in a way GitHub could see It (at the time we couldn't merge directly to Github) but a8dd6d8 was the same commit on master. |
6 tasks
ashb
pushed a commit
that referenced
this pull request
Nov 6, 2018
When running Airflow behind a L7 proxy that sends x-fowarded-* headers, the Flask app miscontructs redirect URIs. Closes #3580 from c4milo/master
galak75
pushed a commit
to VilledeMontreal/incubator-airflow
that referenced
this pull request
Nov 23, 2018
When running Airflow behind a L7 proxy that sends x-fowarded-* headers, the Flask app miscontructs redirect URIs. Closes apache#3580 from c4milo/master
aliceabe
pushed a commit
to aliceabe/incubator-airflow
that referenced
this pull request
Jan 3, 2019
When running Airflow behind a L7 proxy that sends x-fowarded-* headers, the Flask app miscontructs redirect URIs. Closes apache#3580 from c4milo/master
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Jan 23, 2019
When running Airflow behind a L7 proxy that sends x-fowarded-* headers, the Flask app miscontructs redirect URIs. Closes apache#3580 from c4milo/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Airflow behind a L7 proxy that sends
x-fowarded-*headers, the Flask app misconstructs redirect URIs by changing the protocol scheme from https to http. This is not ideal and breaks when SSL is offloaded by such proxy and disabled from airflow.Tests
I tested it manually getting into my running airflow container and inserting the two lines.