New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIRFLOW-2657] Add ability to delete dag from web UI #3531

Closed

Noremac201 wants to merge 1 commit into apache:master from Noremac201:master

Contributor

Noremac201 commented Jun 21, 2018

Make sure you have checked all steps below.

JIRA

My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-2657

Description

Here are some details about my PR, including screenshots of any UI changes:
Add the ability to delete a DAG from the web UI. This uses the airflow.api.common.experimental API that is already in airflow.

Tests

My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"

Code Quality

Passes git diff upstream/master -u -- "*.py" | flake8 --diff

Contributor

Fokko commented Jun 22, 2018

The tests are failing :(


          [AIRFLOW-2657] Add ability to delete dag from web UI

4d9f6be

Noremac201 force-pushed the master branch from f60785d to 4d9f6be Compare

June 22, 2018 15:11

codecov-io commented Jun 22, 2018

Codecov Report

Merging #3531 into master will decrease coverage by 0.12%.
The diff coverage is 26.82%.

@@            Coverage Diff             @@
##           master    #3531      +/-   ##
==========================================
- Coverage   77.46%   77.33%   -0.13%     
==========================================
  Files         204      204              
  Lines       15233    15274      +41     
==========================================
+ Hits        11800    11812      +12     
- Misses       3433     3462      +29

Impacted Files	Coverage Δ
airflow/www_rbac/views.py	`73.85% <20%> (-0.94%)`	⬇️
airflow/www/views.py	`71.63% <33.33%> (-0.54%)`	⬇️
airflow/models.py	`88.31% <0%> (+0.04%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d93d1b...4d9f6be. Read the comment docs.

Contributor Author

Noremac201 commented Jun 22, 2018 •

edited

Loading

Re-basing seemed to fix the tests on this branch.

Thanks

kaxil approved these changes

View reviewed changes

Member

kaxil left a comment

LGTM

asfgit closed this in

702a57e

sekikn pushed a commit to sekikn/airflow that referenced this pull request


          [AIRFLOW-2657] Add ability to delete dag from web UI

c55ccd2

Closes apache#3531 from Noremac201/master

kaxil pushed a commit that referenced this pull request


          [AIRFLOW-2657] Add ability to delete dag from web UI

9ec863a

Closes #3531 from Noremac201/master

galak75 pushed a commit to VilledeMontreal/incubator-airflow that referenced this pull request


          [AIRFLOW-2657] Add ability to delete dag from web UI

f65ce78

Closes apache#3531 from Noremac201/master

XD-DENG added a commit to XD-DENG/airflow that referenced this pull request


          [AIRFLOW-3432] Add test for feature "Delete DAG in UI"

da2a66b

Related Commits:
1. [AIRFLOW-2657](PR apache#3531)
2. [AIRFLOW-3233](PR apache#4069)

Added for both www/ and www_rbac

kaxil pushed a commit that referenced this pull request


          [AIRFLOW-3432] Add test for feature "Delete DAG in UI" (#4266)

1596eca

Related Commits:
1. [AIRFLOW-2657](PR #3531)
2. [AIRFLOW-3233](PR #4069)

Added for both www/ and www_rbac

kaxil pushed a commit that referenced this pull request


          [AIRFLOW-3432] Add test for feature "Delete DAG in UI" (#4266)

7aa4c76

Related Commits:
1. [AIRFLOW-2657](PR #3531)
2. [AIRFLOW-3233](PR #4069)

Added for both www/ and www_rbac

elizabethhalper pushed a commit to cse-airflow/incubator-airflow that referenced this pull request


          [AIRFLOW-3432] Add test for feature "Delete DAG in UI" (apache#4266)

136f450

Related Commits:
1. [AIRFLOW-2657](PR apache#3531)
2. [AIRFLOW-3233](PR apache#4069)

Added for both www/ and www_rbac

XD-DENG mentioned this pull request

[AIRFLOW-3576] Remove unnecessray arg 'root' for /delete in dag.html #4380

Merged

1 task

aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request


          [AIRFLOW-2657] Add ability to delete dag from web UI

cb6bdfa

Closes apache#3531 from Noremac201/master

aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request


          [AIRFLOW-3432] Add test for feature "Delete DAG in UI" (apache#4266)

c452ebc

Related Commits:
1. [AIRFLOW-2657](PR apache#3531)
2. [AIRFLOW-3233](PR apache#4069)

Added for both www/ and www_rbac

kaxil pushed a commit that referenced this pull request


          [AIRFLOW-3432] Add test for feature "Delete DAG in UI" (#4266)

c17946e

Related Commits:
1. [AIRFLOW-2657](PR #3531)
2. [AIRFLOW-3233](PR #4069)

Added for both www/ and www_rbac

ashb pushed a commit to ashb/airflow that referenced this pull request


          [AIRFLOW-3432] Add test for feature "Delete DAG in UI" (apache#4266)

721fc3c

Related Commits:
1. [AIRFLOW-2657](PR apache#3531)
2. [AIRFLOW-3233](PR apache#4069)

Added for both www/ and www_rbac

cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request


          Add ability to delete dag from web UI

27746bd

Closes apache#3531 from Noremac201/master

cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request


          Add test for feature "Delete DAG in UI" (apache#4266)

9f74b2f

Related Commits:
1. [AIRFLOW-2657](PR apache#3531)
2. [AIRFLOW-3233](PR apache#4069)

Added for both www/ and www_rbac

aoen pushed a commit to aoen/incubator-airflow that referenced this pull request


          [AIRFLOW-3060] DAG context manager fails to exit properly in certain …

f4915fc

…circumstances

[AIRFLOW-3123] Use a stack for DAG context management (apache#3956)

[TWTR][AIRFLOW-XXX] Twitter Airflow Customizations + Fixup job scheduling without explicit_defaults_for_timestamp.

[AIRFLOW-3160] Load latest_dagruns asynchronously

[REVBUMP] v9

[AIRFLOW-2861] Add index on log table (apache#3709)

[AIRFLOW-2747][PARTIAL CHERRYPICK] Explicit re-schedule of sensors

[AIRFLOW-3191] Fix not being able to specify execution_date when creating dagrun

[AIRFLOW-2657] Add ability to delete dag from web UI

Closes apache#3531 from Noremac201/master

[REVBUMP] v10

[AIRFLOW-3233] Fix deletion of DAGs in the UI

[AIRFLOW-4070] log.warning for duplicate task dependencies

This change logs a warning on duplicate task dependencies rather than
raising an AirflowException. This will allow automated task
dependencies to be generated while giving the user the option to
explicitly define task dependencies.

Differential Revision: https://phabricator.twitter.biz/D320000

wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request


          [AIRFLOW-3432] Add test for feature "Delete DAG in UI" (apache#4266)

f4705db

Related Commits:
1. [AIRFLOW-2657](PR apache#3531)
2. [AIRFLOW-3233](PR apache#4069)

Added for both www/ and www_rbac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet