-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-2544] Guard against next major release of Celery, Flower #3439
Conversation
@Fokko Here is the PR I proposed yesterday in #2806 (comment) that covers Celery. I also added a similar guard for the 1.0 release of Flower as well. It looks like master was recently changed to |
Codecov Report
@@ Coverage Diff @@
## master #3439 +/- ##
=========================================
Coverage ? 76.68%
=========================================
Files ? 203
Lines ? 15064
Branches ? 0
=========================================
Hits ? 11552
Misses ? 3512
Partials ? 0 Continue to review full report at Codecov.
|
^ Not sure what this Codecov warning is about. This PR doesn't change code, so I think it's not relevant, but please let me know if action is required. |
7b50fb1
to
7d396ad
Compare
Rebased off master to see if it makes a difference. |
@bolkedebruin I noticed you'd done some work around Celery as well. Do you have any input on this one? |
Thanks @tedmiston. Codecov is sometimes a bit off if you're working on an outdated master. Looking good. |
LGTM |
…ry, Flower Closes apache#3439 from tedmiston/celery-flower-guard
Make sure you have checked all steps below.
JIRA
Description
This PR proactively guards against the next major version of Celery (4.2) from being installed automatically until it's been tested. It is currently in RC but not yet officially released. I've also added an upper bound on Flower 1.0 similarly.
Related to https://issues.apache.org/jira/browse/AIRFLOW-1967, and created from discussion in #2806.
Tests
n/a - just a dependency version guard
Commits
Documentation
n/a
Code Quality
git diff upstream/master -u -- "*.py" | flake8 --diff