-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit dnspython to < 2.3.0 until eventlet incompatibitliy is solved #28962
Conversation
@ephraimbuddy @pierrejeambrun -> in case you will be pushing a new version of v2_5_test, likely that one should be cherry-picked. It is only relevant for the reason of constraints - because it turns out that new dnspython is not compatible with the way how cassandra driver + eventlet patch the dnspython during import (and fail) so it would be good when next constraints are regenerated for 2.5, the dnspython is not upgraded to 2.3.0. |
fad4e26
to
5b0e6a3
Compare
The dnspython has been released 2 hours ago and apparently eventlet that cassandra-driver uses is not compatible with the new version. Until the problem is fixed, we should limit dnspython to <2.3.0. Related: eventlet/eventlet#781
5b0e6a3
to
5a6b90f
Compare
Looks like I also had to do the same with "async" extra of Airlow @pierrejeambrun to keep PROD images being built. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the dnspython being added to async packages extra group though?
I think, it is the easiest way to handle the problem. The problem is that whenever eventlet is installed and imported, it attempts to patch dnspython if it finds it during import (!) (and fails when dnspython 2.3.0 is installed). So basically when we install eventlet we should never, ever (until it is fixed) allow dnspython >=2.3.0 to be installed, because importing eventlet will fail 🤷 The only way to do it is to add dnspython in all extras that also install eventlet (we have no other way to limit dnspython but adding it to extra's requires). |
BTW. Kudos to @mik-laj for adding the PROD image unit tests - because those tests (running imports of a number of extras we have there) detected that we also need to fix the async extra. |
All looks good. Merging. |
…28962) The dnspython has been released 2 hours ago and apparently eventlet that cassandra-driver uses is not compatible with the new version. Until the problem is fixed, we should limit dnspython to <2.3.0. Related: eventlet/eventlet#781 (cherry picked from commit d169df7)
The dnspython has been released 2 hours ago and apparently eventlet that cassandra-driver uses is not compatible with the new version.
Until the problem is fixed, we should limit dnspython to <2.3.0.
Related: eventlet/eventlet#781
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.