Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename kubernetes config section to kubernetes_executor #26873

Merged
merged 8 commits into from
Oct 12, 2022

Conversation

dstandish
Copy link
Contributor

@dstandish dstandish commented Oct 4, 2022

Now that KPO does not consider any core k8s config params, this section truly is just about kubernetes executor. Renaming it reduces potential for confusion.

@dstandish dstandish force-pushed the rename-k8s-section-to-k8s-executor branch from e07e646 to 31106ad Compare October 11, 2022 01:42
@dstandish dstandish marked this pull request as ready for review October 11, 2022 05:42
@dstandish dstandish force-pushed the rename-k8s-section-to-k8s-executor branch from 83c657f to f20784f Compare October 11, 2022 06:27
@dstandish dstandish added this to the Airflow 2.5.0 milestone Oct 12, 2022
@dstandish dstandish force-pushed the rename-k8s-section-to-k8s-executor branch from 01789fe to ccae4f9 Compare October 12, 2022 19:25
@dstandish dstandish force-pushed the rename-k8s-section-to-k8s-executor branch from ccae4f9 to 19b978d Compare October 12, 2022 19:52
@dstandish dstandish merged commit 21e550e into apache:main Oct 12, 2022
@dstandish dstandish deleted the rename-k8s-section-to-k8s-executor branch October 12, 2022 21:14
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Oct 18, 2022
@tanvn
Copy link
Contributor

tanvn commented Dec 7, 2022

Hi, today I tried upgrading to 2.5.0 with helm-chart version 1.7.0 and found the following warning messages

> (app-root) bash-4.2$ airflow version
/opt/app-root/lib64/python3.8/site-packages/airflow/cli/cli_parser.py:905 DeprecationWarning: The namespace option in [kubernetes] has been moved to the namespace option in [kubernetes_executor] - the old setting has been used, but please update your config.
/opt/rh/rh-python38/root/usr/lib64/python3.8/configparser.py:408 FutureWarning: The config section [kubernetes] has been renamed to [kubernetes_executor]. Please update your `conf.get*` call to use the new name
2.5.0

I think we have to update this part:
https://github.com/apache/airflow/blob/main/chart/values.yaml#L1731

to change from kubernetes to kubernetes_executor as well, WDYT? @dstandish @uranusjr @potiuk

@dstandish
Copy link
Contributor Author

dstandish commented Dec 7, 2022

Bad warning resolved here #28109

But yes there may be chart updates that need to happen

Make pr?

@tanvn
Copy link
Contributor

tanvn commented Dec 7, 2022

@dstandish
Thank for the information.
I understood.
Let me create a PR for this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants