Fix airflow db reset when dangling tables exist
#25441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one of the "dangling" tables already existed in the DB, performing an `airflow db reset` would delete the tables, but it would then try and _re-create_ the table later. This was because the Table object was still associated with the Metadata object. The fix is to remove the it from Metadata once we have dropped it.
ephraimbuddy
approved these changes
Aug 1, 2022
Two lines up we got the table name from doing |
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 15, 2022
If one of the "dangling" tables already existed in the DB, performing an `airflow db reset` would delete the tables, but it would then try and _re-create_ the table later. This was because the Table object was still associated with the Metadata object. The fix is to remove the it from Metadata once we have dropped it. (cherry picked from commit 40eefd8)
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one of the "dangling" tables already existed in the DB, performing an
airflow db resetwould delete the tables, but it would then try and re-create the table later. This was because the Table object was still associated with the Metadata object.The fix is to remove the it from Metadata once we have dropped it.