Serialize pod_override to JSON before pickling executor_config #24356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
force-pushed
the
serialize-pod_override-before-pickle-executor-config
branch
from
8a6a0a5 to
3a2dbeb
Compare
|
Not sure if this impacts things: but executor config can be used for other executors too |
|
Yeah I tried to be mindful of that. I don't just serialize the whole executor config. I only serialize the |
2 tasks
dstandish
force-pushed
the
serialize-pod_override-before-pickle-executor-config
branch
from
3a2dbeb to
9f1a16c
Compare
dstandish
force-pushed
the
serialize-pod_override-before-pickle-executor-config
branch
3 times, most recently
from
e21c922 to
769efd9
Compare
jedcunningham
approved these changes
Jun 22, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
If we unpickle a k8s object that was pickled under an earlier k8s library version, then the unpickled object may throw an error when to_dict is called. To be more tolerant of version changes we convert to JSON using Airflow's serializer before pickling.
dstandish
force-pushed
the
serialize-pod_override-before-pickle-executor-config
branch
from
258a90a to
6255d97
Compare
potiuk
approved these changes
Jul 4, 2022
|
Random failure. Merging. |
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 19, 2022
* Serialize pod_override to JSON before pickling executor_config If we unpickle a k8s object that was pickled under an earlier k8s library version, then the unpickled object may throw an error when to_dict is called. To be more tolerant of version changes we convert to JSON using Airflow's serializer before pickling. (cherry picked from commit c1d621c)
53 tasks
Closed
2 tasks
2 tasks
uranusjr
deleted the
serialize-pod_override-before-pickle-executor-config
branch
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we unpickle a k8s object that was pickled under an earlier k8s library version, then the unpickled object may throw an error when to_dict is called. To be more tolerant of version changes we convert to JSON using Airflow's serializer before pickling.