-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cope with '%' in password when waiting for migrations #12440
Cope with '%' in password when waiting for migrations #12440
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thin the proposed solutin is not good - see the comment.
I see! |
Awesome work, congrats on your first merged pull request! |
(cherry picked from commit d4c3d32)
(cherry picked from commit d4c3d32)
(cherry picked from commit d4c3d32)
(cherry picked from commit d4c3d32)
When there is a '%' in the sql connection url, wait-for-airflow-migrations container complains no permission to connect database.
This commit fix that issue by replacing '%' with '%%'.
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.