Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cope with '%' in password when waiting for migrations #12440

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

highfly22
Copy link
Contributor


When there is a '%' in the sql connection url, wait-for-airflow-migrations container complains no permission to connect database.
This commit fix that issue by replacing '%' with '%%'.

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Nov 18, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 18, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thin the proposed solutin is not good - see the comment.

@potiuk
Copy link
Member

potiuk commented Nov 18, 2020

I see!

@potiuk potiuk merged commit d4c3d32 into apache:master Nov 18, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 18, 2020

Awesome work, congrats on your first merged pull request!

potiuk pushed a commit that referenced this pull request Nov 29, 2020
@potiuk potiuk added this to the Airflow 1.10.14 milestone Nov 30, 2020
@potiuk potiuk added the type:improvement Changelog: Improvements label Nov 30, 2020
kaxil pushed a commit that referenced this pull request Dec 3, 2020
ashb pushed a commit that referenced this pull request Dec 3, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants