Single/Multi-Namespace mode for helm chart #11034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @sjmiller609 |
mik-laj
reviewed
Sep 20, 2020
| kind: ClusterRole | ||
| {{- else }} | ||
| kind: Role |
There was a problem hiding this comment.
when you create a Role, you have to specify the namespace it belongs in.
ClusterRole, by contrast, is a non-namespaced resource.
https://kubernetes.io/docs/reference/access-authn-authz/rbac/
Can you add namespace?
|
Thanks for addressing this issue. I've also encountered this problem recently when I was creating an environment for multiple teams on one cluster. For now, I've added this option, but I think it's worth solving this problem. |
mik-laj
reviewed
Sep 21, 2020
| # yamllint enable rule:line-length | ||
|
|
||
| multiNamespaceMode: 'False' |
There was a problem hiding this comment.
Should we also update README.md? The minimum is updating the reference documentation, but I'd be happy if you would describe more about what "Multi namespace mode" means.
Reference documentation will be easier to maintain if validation for values.yml has been added.
#10664
|
Can you do rebase and update values.json? |
dimberman
force-pushed
the
multi-namespace-helm
branch
from
28f7520 to
3968395
Compare
|
@mik-laj rebased |
|
Can you add new item to values.schema.json? |
|
@mik-laj added |
mik-laj
approved these changes
Sep 22, 2020
kaxil
approved these changes
Sep 22, 2020
Users should not REQUIRE a ClusterRole/ClusterRolebinding to run airflow via helm. This change will allow "single" and "multi" namespace modes so users can add airflow to managed kubernetes clusters
dimberman
force-pushed
the
multi-namespace-helm
branch
from
74d0e93 to
9753cb7
Compare
FloChehab
pushed a commit
to MeilleursAgents/airflow
that referenced
this pull request
Oct 20, 2020
* Followup to apache#11034 * Was not referencing the correct kind of resources if multiNamespaceMode = False
dimberman
pushed a commit
that referenced
this pull request
Oct 20, 2020
* Followup to #11034 * Was not referencing the correct kind of resources if multiNamespaceMode = False
michalmisiewicz
pushed a commit
to michalmisiewicz/airflow
that referenced
this pull request
Oct 30, 2020
* Followup to apache#11034 * Was not referencing the correct kind of resources if multiNamespaceMode = False
potiuk
pushed a commit
that referenced
this pull request
Nov 15, 2020
* Multi-Namespace mode for helm chart Users should not REQUIRE a ClusterRole/ClusterRolebinding to run airflow via helm. This change will allow "single" and "multi" namespace modes so users can add airflow to managed kubernetes clusters * add namespace to role * add rolebinding too * add docs * add values.schema.json change (cherry picked from commit 93475e9)
potiuk
pushed a commit
that referenced
this pull request
Nov 15, 2020
potiuk
pushed a commit
that referenced
this pull request
Nov 16, 2020
* Multi-Namespace mode for helm chart Users should not REQUIRE a ClusterRole/ClusterRolebinding to run airflow via helm. This change will allow "single" and "multi" namespace modes so users can add airflow to managed kubernetes clusters * add namespace to role * add rolebinding too * add docs * add values.schema.json change (cherry picked from commit 93475e9)
potiuk
pushed a commit
that referenced
this pull request
Nov 16, 2020
potiuk
pushed a commit
that referenced
this pull request
Nov 16, 2020
* Multi-Namespace mode for helm chart Users should not REQUIRE a ClusterRole/ClusterRolebinding to run airflow via helm. This change will allow "single" and "multi" namespace modes so users can add airflow to managed kubernetes clusters * add namespace to role * add rolebinding too * add docs * add values.schema.json change (cherry picked from commit 93475e9)
potiuk
pushed a commit
that referenced
this pull request
Nov 16, 2020
kaxil
pushed a commit
that referenced
this pull request
Nov 18, 2020
* Multi-Namespace mode for helm chart Users should not REQUIRE a ClusterRole/ClusterRolebinding to run airflow via helm. This change will allow "single" and "multi" namespace modes so users can add airflow to managed kubernetes clusters * add namespace to role * add rolebinding too * add docs * add values.schema.json change (cherry picked from commit 93475e9)
kaxil
pushed a commit
that referenced
this pull request
Nov 18, 2020
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
* Multi-Namespace mode for helm chart Users should not REQUIRE a ClusterRole/ClusterRolebinding to run airflow via helm. This change will allow "single" and "multi" namespace modes so users can add airflow to managed kubernetes clusters * add namespace to role * add rolebinding too * add docs * add values.schema.json change (cherry picked from commit 93475e9)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
* Followup to apache#11034 * Was not referencing the correct kind of resources if multiNamespaceMode = False (cherry picked from commit 3391c90)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users should not REQUIRE a ClusterRole/ClusterRolebinding
to run airflow via helm. This change will allow "single" and "multi"
namespace modes so users can add airflow to managed kubernetes clusters
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.