This repository was archived by the owner on Dec 10, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 271
feat(query): add makeApi
API generator
#666
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a makeApi API generator to easily add typed query methods for new (and existing) API endpoints.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/ifhisvw2r |
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
==========================================
+ Coverage 24.37% 25.13% +0.76%
==========================================
Files 329 332 +3
Lines 7517 7594 +77
Branches 900 929 +29
==========================================
+ Hits 1832 1909 +77
Misses 5598 5598
Partials 87 87
Continue to review full report at Codecov.
|
Closed
kristw
approved these changes
Jul 8, 2020
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
Add a
makeApi
Superset API generator and enhance thecallApi
method to supportsearchParams
for GET requests.Related: