Skip to content
This repository was archived by the owner on Dec 10, 2021. It is now read-only.

feat(query): add makeApi API generator #666

Merged
merged 9 commits into from
Jul 8, 2020

Conversation

ktmud
Copy link
Contributor

@ktmud ktmud commented Jul 3, 2020

🏆 Enhancements

Add a makeApi Superset API generator and enhance the callApi method to support searchParams for GET requests.

Related:

ktmud added 2 commits July 2, 2020 17:48
Introduce a makeApi API generator to easily add typed query methods for new (and existing) API endpoints.
@ktmud ktmud requested a review from a team as a code owner July 3, 2020 09:33
@vercel
Copy link

vercel bot commented Jul 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/ifhisvw2r
✅ Preview: https://superset-ui-git-fork-ktmud-superset-query.superset.vercel.app

@vercel vercel bot temporarily deployed to Preview July 3, 2020 09:33 Inactive
@vercel vercel bot temporarily deployed to Preview July 3, 2020 09:37 Inactive
@codecov
Copy link

codecov bot commented Jul 4, 2020

Codecov Report

Merging #666 into master will increase coverage by 0.76%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
+ Coverage   24.37%   25.13%   +0.76%     
==========================================
  Files         329      332       +3     
  Lines        7517     7594      +77     
  Branches      900      929      +29     
==========================================
+ Hits         1832     1909      +77     
  Misses       5598     5598              
  Partials       87       87              
Impacted Files Coverage Δ
...t-ui-query/src/api/legacy/getDatasourceMetadata.ts 100.00% <ø> (ø)
...ckages/superset-ui-query/src/extractQueryFields.ts 100.00% <ø> (ø)
...kages/superset-ui-query/src/types/QueryFormData.ts 100.00% <ø> (ø)
...s/superset-ui-query/test/api/setupClientForTest.ts 100.00% <ø> (ø)
.../superset-ui-connection/src/SupersetClientClass.ts 100.00% <100.00%> (ø)
...ages/superset-ui-connection/src/callApi/callApi.ts 100.00% <100.00%> (ø)
...uperset-ui-connection/src/callApi/parseResponse.ts 100.00% <100.00%> (ø)
packages/superset-ui-connection/src/constants.ts 100.00% <100.00%> (ø)
...perset-ui-query/src/api/legacy/fetchExploreJson.ts 100.00% <100.00%> (ø)
...es/superset-ui-query/src/api/legacy/getFormData.ts 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dcdc73...c5aba1b. Read the comment docs.

@vercel vercel bot temporarily deployed to Preview July 5, 2020 08:15 Inactive
@ktmud ktmud force-pushed the superset-query branch from da3d56c to c5aba1b Compare July 7, 2020 22:16
@ktmud ktmud merged commit 653f3d9 into apache-superset:master Jul 8, 2020
@ktmud ktmud deleted the superset-query branch July 8, 2020 00:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants