Renew cert fix #166
Merged
Renew cert fix #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-kobets-epam
force-pushed
the
renew-cert-fix
branch
3 times, most recently
from
cb28fff to
1153248
Compare
al1img
reviewed
Oct 23, 2024
smclient/smclient.go
Outdated
|
|
||
| if client.stream != nil { | ||
| if err := client.stream.CloseSend(); err != nil { | ||
| log.WithField("err", err).Error("SMClient failed send close") |
smclient/smclient.go
Outdated
| @@ -332,7 +362,7 @@ func (client *SMClient) processMessages() (err error) { | |||
| if err != nil { | |||
| if code, ok := status.FromError(err); ok { | |||
| if code.Code() == codes.Canceled { | |||
| log.Debug("SM client connection closed") | |||
| log.Debug("CM client connection closed") | |||
mykola-kobets-epam
force-pushed
the
renew-cert-fix
branch
from
1153248 to
f7038c4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #166 +/- ##
===========================================
- Coverage 67.73% 66.87% -0.86%
===========================================
Files 23 21 -2
Lines 4128 4091 -37
===========================================
- Hits 2796 2736 -60
- Misses 840 857 +17
- Partials 492 498 +6 ☔ View full report in Codecov by Sentry. |
mykola-kobets-epam
force-pushed
the
renew-cert-fix
branch
from
d1b5567 to
05deeb8
Compare
Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
mykola-kobets-epam
force-pushed
the
renew-cert-fix
branch
from
05deeb8 to
9ea867d
Compare
|
MykolaSolyanko
approved these changes
Oct 25, 2024
al1img
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.