Fix launcher #274
Merged
Fix launcher #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #274 +/- ##
========================================
Coverage 83.65% 83.65%
========================================
Files 157 157
Lines 13990 13990
Branches 1738 1738
========================================
Hits 11704 11704
Misses 2286 2286 ☔ View full report in Codecov by Sentry. |
Current sort methods use temporary storage defined on stack. It leads to huge stack consumption for bit structures. Add separate methods to perform sorting using external temporary storage. Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
ServiceData is required by Instance to perform Start/Stop operations. In current implementation we set service data with separate method `SetService` and pass pointer to cached service. This approach consumed less memory but requires accurate watching for cached services. Add ServiceData as Instance member and pass service data through Instance constructor. It makes service data handling inside instance more safe. Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
Current approach doesn't properly calculate instances that should be stopped and started on run instances command. Reimplement this calculation by adding 'CalculateInstances' function. This function calculate instances that should be stopped and started based on currently running instances and desired instances received in run instances request. This function is implemented in the following way: * if desired instance ident not in current instances list, add this instance to start list; * if desired instance ident is in current instances list, check if instance data, or service version are changed, or restart all instances is requested. In this case, add this item to start and stop lists; * add all instances from current instances list that are not in desired list to stop list. This commit also updates the unit test that check run instances API. Test data is taken from golang sm implementation to make sure that it behaves in the same way. Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
mlohvynenko
approved these changes
Feb 27, 2025
MykolaSolyanko
approved these changes
Feb 27, 2025
We don't have branches with 'branch*' pattern. Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.