Fix defaul stack configuration #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should reset mLaunchInProgress in case of error, otherwise threads depending on this flag will block forever. Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #273 +/- ##
===========================================
- Coverage 83.65% 83.58% -0.08%
===========================================
Files 157 157
Lines 13990 13971 -19
Branches 1738 1735 -3
===========================================
- Hits 11704 11677 -27
- Misses 2286 2294 +8 ☔ View full report in Codecov by Sentry. |
mlohvynenko
approved these changes
Feb 24, 2025
MykolaSolyanko
approved these changes
Feb 24, 2025
mykola-kobets-epam
approved these changes
Feb 24, 2025
mlohvynenko
reviewed
Feb 26, 2025
| @@ -61,7 +61,7 @@ class Thread : private NonCopyable { | |||
| */ | |||
| ~Thread() | |||
| { | |||
| #if AOS_CONFIG_THREAD_STACK_GUARD_SIZE != 0 | |||
| #if AOS_CONFIG_THREAD_STACK_GUARD_SIZE != 0 && AOS_CONFIG_THREAD_STACK_USAGE | |||
There was a problem hiding this comment.
please disable include of #include <sys/mman.h> as well
Currently, we define and configure stack by default. It is not convenient as each platform has own minimal stack size that may differ from our stack size. Change stack configuration default behaviour as following: * use auto stack configuration by default: (AOS_CONFIG_THREAD_DEFAULT_STACK_SIZE=0). Do not define or manually configure thread stack; * disable stack usage API by default: (AOS_CONFIG_THREAD_STACK_USAGE=0). Enabling this option requires manual stack size alignment and configuration. AOS_CONFIG_THREAD_DEFAULT_STACK_SIZE and AOS_CONFIG_THREAD_STACK_ALIGN should be define. This option defines stack as static buffer with specified size and alignment and used pthread_attr_setstack API to set thread stack. In all other cases, dedicated pthread API used to configure stack (pthread_attr_setstacksize, pthread_attr_setguardsize). Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.