[servicemanager] Return desired services/layers statuses #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlohvynenko
force-pushed
the
validate_layer
branch
from
99caf11 to
23b1867
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #249 +/- ##
===========================================
+ Coverage 83.72% 83.75% +0.02%
===========================================
Files 157 157
Lines 14041 14242 +201
Branches 1739 1756 +17
===========================================
+ Hits 11756 11928 +172
- Misses 2285 2314 +29 ☔ View full report in Codecov by Sentry. |
mlohvynenko
force-pushed
the
validate_layer
branch
11 times, most recently
from
eb52d70 to
47bfc54
Compare
mlohvynenko
changed the title
al1img
reviewed
Feb 10, 2025
| @@ -330,6 +292,87 @@ Error ServiceManager::RemoveItem(const String& id) | |||
| * Private | |||
| **********************************************************************************************************************/ | |||
|
|
|||
| RetWithError<UniquePtr<ServiceInfoStaticArray>> ServiceManager::ProcessAlreadyInstalledServices( | |||
There was a problem hiding this comment.
Not so good API, unclear what is returned without looking inside function. I recommend either return it through named param, Or even better to divide into two separate funcitons.
There was a problem hiding this comment.
Refactored to accept via param
mlohvynenko
force-pushed
the
validate_layer
branch
5 times, most recently
from
a5ad8ca to
1ec7511
Compare
Signed-off-by: Mykhailo Lohvynenko <Mykhailo_Lohvynenko@epam.com>
Signed-off-by: Mykhailo Lohvynenko <Mykhailo_Lohvynenko@epam.com>
Signed-off-by: Mykhailo Lohvynenko <Mykhailo_Lohvynenko@epam.com>
Signed-off-by: Mykhailo Lohvynenko <Mykhailo_Lohvynenko@epam.com>
Signed-off-by: Mykhailo Lohvynenko <Mykhailo_Lohvynenko@epam.com>
mlohvynenko
force-pushed
the
validate_layer
branch
from
1ec7511 to
02bb015
Compare
|
al1img
approved these changes
Mar 4, 2025
MykolaSolyanko
approved these changes
Mar 4, 2025
mykola-kobets-epam
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.