Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utils] Use core common lib converter #99

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

mlohvynenko
Copy link
Member

No description provided.

@mlohvynenko mlohvynenko changed the title Refactor pbconvert [utils] Use core common lib converter Jan 16, 2025
@mlohvynenko mlohvynenko changed the base branch from feature_sm_cpp to develop January 28, 2025 10:07
Signed-off-by: Mykhailo Lohvynenko <Mykhailo_Lohvynenko@epam.com>
Signed-off-by: Mykhailo Lohvynenko <Mykhailo_Lohvynenko@epam.com>
Signed-off-by: Mykhailo Lohvynenko <Mykhailo_Lohvynenko@epam.com>
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 59.57447% with 19 lines in your changes missing coverage. Please review.

Project coverage is 86.24%. Comparing base (b4dbb1e) to head (21978b8).
Report is 114 commits behind head on develop.

Files with missing lines Patch % Lines
src/iamserver/protectedmessagehandler.cpp 43.75% 9 Missing ⚠️
src/iamserver/nodecontroller.cpp 22.22% 7 Missing ⚠️
src/iamserver/publicmessagehandler.cpp 89.47% 2 Missing ⚠️
src/iamserver/publicmessagehandler.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #99      +/-   ##
===========================================
- Coverage    87.61%   86.24%   -1.37%     
===========================================
  Files           43       39       -4     
  Lines         3092     5031    +1939     
  Branches       225      401     +176     
===========================================
+ Hits          2709     4339    +1630     
- Misses         383      692     +309     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@al1img al1img merged commit c876853 into aosedge:develop Jan 28, 2025
4 of 5 checks passed
@mlohvynenko mlohvynenko deleted the refactor_pbconvert branch February 25, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants