Add MergedMigrationPath to aos_iamanager.cfg #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-kobets-epam
force-pushed
the
iam-migration-fix
branch
2 times, most recently
from
dfd6235 to
46df98e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #92 +/- ##
===========================================
- Coverage 87.61% 85.51% -2.10%
===========================================
Files 43 49 +6
Lines 3092 5205 +2113
Branches 225 419 +194
===========================================
+ Hits 2709 4451 +1742
- Misses 383 754 +371 ☔ View full report in Codecov by Sentry. |
mykola-kobets-epam
force-pushed
the
iam-migration-fix
branch
4 times, most recently
from
934e2a0 to
eba5d30
Compare
Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
mykola-kobets-epam
force-pushed
the
iam-migration-fix
branch
from
eba5d30 to
115f208
Compare
mykola-kobets-epam
changed the title
mlohvynenko
approved these changes
Dec 10, 2024
al1img
reviewed
Dec 10, 2024
src/database/database.cpp
Outdated
| @@ -38,7 +38,8 @@ Database::Database() | |||
| Poco::Data::SQLite::Connector::registerConnector(); | |||
| } | |||
|
|
|||
| aos::Error Database::Init(const std::string& dbPath, const std::string& migrationPath) | |||
| aos::Error Database::Init( | |||
There was a problem hiding this comment.
Can we pass config reference instead?
There was a problem hiding this comment.
There is no entry in the config for dbPath:
App class uses dbPath Poco::Path(config.mValue.mWorkingDir, cDBFileName).toString(),
Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
mykola-kobets-epam
force-pushed
the
iam-migration-fix
branch
from
fab7b32 to
6f03d68
Compare
al1img
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.