[utils,grpchelpers] Remove GracefulStop call on close grpc server #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlohvynenko
approved these changes
Dec 19, 2024
MykolaSolyanko
approved these changes
Dec 19, 2024
Calling GracefulStop after Stop doesn't make sens as Stop already released all resources. Remove Stop and keep only GracefulStop. Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
al1img
force-pushed
the
fix_close_grpc
branch
from
a2ea2a0 to
1feefa8
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling GracefulStop after Stop doesn't make sens as Stop already released all resources. Also, with current grpc version GracefulStop freezes even all clients streams are closed.