Remove payload from AlertItem #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mykola-kobets-epam
changed the title
mykola-kobets-epam
force-pushed
the
remove-payload-from-alert-item
branch
7 times, most recently
from
f0d1302 to
252f5a6
Compare
MykolaSolyanko
approved these changes
Jul 26, 2024
al1img
reviewed
Jul 26, 2024
| @@ -52,22 +52,30 @@ const ( | |||
| /*********************************************************************************************************************** | |||
| * Types | |||
| **********************************************************************************************************************/ | |||
| // AlertItem common alert data. | |||
| @@ -1233,43 +1234,13 @@ func (host *testInstancesUsage) FillSystemInfo(instanceID string, instance *inst | |||
| return nil | |||
| } | |||
|
|
|||
| func AlertsEqual(alert1, alert2 interface{}) bool { | |||
There was a problem hiding this comment.
Make this commit first and use alertutils directly.
There was a problem hiding this comment.
cant reorder commits because alertutils depend on refactoring alerts in its implementation.
| // AlertsPayloadEqual compares alerts ignoring timestamp. | ||
| // | ||
| //nolint:funlen | ||
| func AlertsPayloadEqual(alert1, alert2 interface{}) bool { |
There was a problem hiding this comment.
Would be nice to add minimalistic unit test.
mlohvynenko
approved these changes
Jul 26, 2024
Signed-off-by: Mykola <mykola_kobets@epam.com>
Signed-off-by: Mykola <mykola_kobets@epam.com>
mykola-kobets-epam
force-pushed
the
remove-payload-from-alert-item
branch
from
252f5a6 to
8d47252
Compare
|
al1img
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.