Revert "Allow 0 fromBlock, toBlock values (web3#3089)"

This reverts commit c51c3b9.
aonjintana · Oct 25, 2019 · 38a7f61 · 38a7f61
1 parent 9dd09db
commit 38a7f61
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 111 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -65,7 +65,6 @@ Released with 1.0.0-beta.37 code base.
 
 ### Fixed
 
-- Fix allow `0` as a valid `fromBlock` or `toBlock` filter param (#1100)
 - Fix randomHex returning inconsistent string lengths (#1490)
 - Fix make isBN minification safe (#1777)
 - Fix incorrect references to BigNumber in utils.fromWei and utils.toWei error messages (#2468)

diff --git a/packages/web3-core-helpers/src/formatters.js b/packages/web3-core-helpers/src/formatters.js
@@ -279,10 +279,10 @@ var inputLogFormatter = function(options) {
             return utils.fromUtf8(value);
     };
 
-    if (options.fromBlock || options.fromBlock === 0)
+    if (options.fromBlock)
         options.fromBlock = inputBlockNumberFormatter(options.fromBlock);
 
-    if (options.toBlock || options.toBlock === 0)
+    if (options.toBlock)
         options.toBlock = inputBlockNumberFormatter(options.toBlock);
 
 

diff --git a/test/formatters.inputLogFormatter.js b/test/formatters.inputLogFormatter.js