Carry over buffered tasks across BP sessions #5169
Open
+213
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoqun
commented
Mar 6, 2025
| @@ -1487,7 +1548,9 @@ impl<S: SpawnableScheduler<TH>, TH: TaskHandler> ThreadManager<S, TH> { | |||
| session_result_sender | |||
| .send(result_with_timings) | |||
| .expect("always outlived receiver"); | |||
| state_machine.reinitialize(); | |||
| if matches!(scheduling_mode, BlockVerification) { | |||
| state_machine.reinitialize(); | |||
There was a problem hiding this comment.
so, state_machine won't be reinitialize()-d for BlockProduction anymore. along with this, proper (Tasks-related) oom mitigation will be addressed by later pr, while that concern is temporarily becoming more prominent as of this pr.
ryoqun
commented
Mar 6, 2025
| @@ -3014,17 +3082,53 @@ mod tests { | |||
| let bank = Bank::new_for_tests(&genesis_config); | |||
| let (bank, _bank_forks) = setup_dummy_fork_graph(bank); | |||
| let ignored_prioritization_fee_cache = Arc::new(PrioritizationFeeCache::new(0u64)); | |||
| let pool = SchedulerPool::<PooledScheduler<StallingHandler>, _>::new_dyn( | |||
| let pool = SchedulerPool::<PooledScheduler<StallingHandler>, _>::new( | |||
There was a problem hiding this comment.
needed to call .register_banking_stage(), which is outside the dyn trait definition.
ryoqun
force-pushed
the
cross-session-carry-over
branch
from
ede407c to
9b3163f
Compare
ryoqun
force-pushed
the
cross-session-carry-over
branch
from
9b3163f to
1851179
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
because leader scheduler is grouped by 4 consecutive slots, special treatment is needed for very efficient hangover across banks.
Summary of Changes
Now that #4949 has landed, it's now possible for the (singleton) block production unified scheduler to carry over buffered tasks to next bank (= session) seamlessly with customized session switching conditions.
also note that there should be no functional change to block verification scheduler behavior.
extracted from #3946