Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.2: Fix flaky banking stage tests (backport of #5160) #5165

Open
wants to merge 2 commits into
base: v2.2
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Mar 6, 2025

Problem

Some banking stage tests try to process some transactions within the first block of a cluster with slow poh. If for some reason the transaction isn't included before poh ticks to the 2nd to last tick in the first block (takes about ~3.2s (8 * 400ms)), the test will never end because the poh loop stops recording transaction mixins.

Summary of Changes

  • Make slow poh even slower by increase ticks per slot by a factor of 1024 (blocks will be over 6min long)
  • Exit low power poh loop as soon as exit is set

Fixes #


This is an automatic backport of pull request #5160 done by [Mergify](https://mergify.com).

(cherry picked from commit 433f4ff)

# Conflicts:
#	core/src/banking_stage.rs
@mergify mergify bot added the conflicts label Mar 6, 2025
@mergify mergify bot requested a review from a team as a code owner March 6, 2025 04:57
Copy link
Author

mergify bot commented Mar 6, 2025

Cherry-pick of 433f4ff has failed:

On branch mergify/bp/v2.2/pr-5160
Your branch is up to date with 'origin/v2.2'.

You are currently cherry-picking commit 433f4ffe1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   core/src/banking_stage.rs

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot assigned jstarry Mar 6, 2025
@steviez steviez requested a review from apfitzge March 6, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants