Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky gossip ping test #5162

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

jstarry
Copy link

@jstarry jstarry commented Mar 6, 2025

Problem

Randomly generated socket addresses in the gossip ping test sometimes get generated with port 0 which causes packets to be discarded and the test to fail

Summary of Changes

Skip generated socket addresses with port 0

Fixes #

@jstarry jstarry requested a review from behzadnouri March 6, 2025 00:16
@jstarry
Copy link
Author

jstarry commented Mar 6, 2025

@jstarry jstarry merged commit 76fd977 into anza-xyz:master Mar 6, 2025
47 checks passed
@jstarry jstarry deleted the fix/flaky-gossip-ping-test branch March 6, 2025 14:22
@jstarry jstarry added the v2.2 Backport to v2.2 branch label Mar 6, 2025
Copy link

mergify bot commented Mar 6, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Mar 6, 2025
(cherry picked from commit 76fd977)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.2 Backport to v2.2 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants