Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - test_syscall_get_sysvar #5161

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

Lichtso
Copy link

@Lichtso Lichtso commented Mar 5, 2025

Problem

An incorrect test setup lead to failures in the CI, which got triggered by #5155.

Summary of Changes

Moves temporary Pubkeys into surrounding scope to pin MemoryMapping.

@Lichtso Lichtso requested a review from alexpyattaev March 5, 2025 22:16
Copy link

mergify bot commented Mar 5, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@Lichtso Lichtso requested a review from LucasSte March 5, 2025 22:23
Copy link

@alexpyattaev alexpyattaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Lichtso Lichtso marked this pull request as ready for review March 5, 2025 23:28
@Lichtso Lichtso requested a review from a team as a code owner March 5, 2025 23:28
@Lichtso Lichtso merged commit 3ad2880 into anza-xyz:master Mar 6, 2025
47 checks passed
@Lichtso Lichtso deleted the fix/test_syscall_get_sysvar branch March 6, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants