Fix - Invoke non program account owned by a builtin #5158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
fix/invoke_non_program_account_owned_by_a_builtin
branch
from
1738f1c to
ad7759a
Compare
…oader owned or non built-in account.
Lichtso
force-pushed
the
fix/invoke_non_program_account_owned_by_a_builtin
branch
from
ad7759a to
64d3113
Compare
Lichtso
commented
Mar 5, 2025
| @@ -13556,15 +13596,15 @@ fn test_loader_v3_to_v4_migration() { | |||
| finalized_migration_transaction.clone(), | |||
| Err(TransactionError::InstructionError( | |||
| 0, | |||
| InstructionError::InvalidInstructionData, | |||
| InstructionError::UnsupportedProgramId, | |||
There was a problem hiding this comment.
This is where I first noticed this issue.
LucasSte
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently there is a slight bug once
remove_accounts_executable_flag_checksis active:One can invoke a built-in program by invoking any account owned by it instead. This leads to the built-in running as a different pubkey, thus all ownership checks fail and the built-in has no write access to anything.
This is benign as it only allows invoking built-in programs in a strange nonsensical way. But, it is still a stupid thing to support and would hinder future protocol changes such as these in the account loader.
About rekeying: Well see Discord discussion.
Summary of Changes
Blocks the execution of any non loader owned or non built-in account and adds
test_invoke_non_program_account_owned_by_a_builtin()to demonstrate the change in behavior.Feature Gate Issue: https://github.com/anza-xyz/feature-gate-tracker/issues/69