v2.2: Remove ignored default-features key from Cargo.toml files (backport of #4878)

[mergify]

Problem

default-features is ignored for solana-program, and other sdk dependencies, since default-features was not specified for workspace.dependencies.solana-program.

Summary of Changes

Remove default-features key from Cargo.toml files.

---

This is an automatic backport of pull request #4878 done by [Mergify](https://mergify.com).

[steviez]

Justification for BP - current tip of v2.2 spits out these warning when building:

warning: /.../src/solana/transaction-status-client-types/Cargo.toml: `default-features` is ignored for solana-signature, since `default-features` was not specified for `workspace.dependencies.solana-signature`, this could become a hard error in the future
warning: /.../src/solana/account-decoder/Cargo.toml: `default-features` is ignored for solana-program, since `default-features` was not specified for `workspace.dependencies.solana-program`, this could become a hard error in the future
warning: /.../src/solana/svm/Cargo.toml: `default-features` is ignored for solana-program, since `default-features` was not specified for `workspace.dependencies.solana-program`, this could become a hard error in the future
warning: /.../src/solana/inline-spl/Cargo.toml: `default-features` is ignored for solana-pubkey, since `default-features` was not specified for `workspace.dependencies.solana-pubkey`, this could become a hard error in the future
warning: /.../src/solana/rpc-client/Cargo.toml: `default-features` is ignored for solana-program, since `default-features` was not specified for `workspace.dependencies.solana-program`, this could become a hard error in the future
warning: /.../src/solana/perf/Cargo.toml: `default-features` is ignored for solana-pubkey, since `default-features` was not specified for `workspace.dependencies.solana-pubkey`, this could become a hard error in the future
warning: /.../src/solana/quic-client/Cargo.toml: `default-features` is ignored for solana-pubkey, since `default-features` was not specified for `workspace.dependencies.solana-pubkey`, this could become a hard error in the future

[steviez]

Rebased on tip of v2.2 to pick up 997abca for Windows CI

[t-nelson]

is this not the opposite of what we want to do? should instead not use the workspace dependency declaration and instead use a minimal features declaration

[LucasSte]

is this not the opposite of what we want to do? should instead not use the workspace dependency declaration and instead use a minimal features declaration

Do you mean listing the features separately for each crate? I believe the original intent of removing the default features was to avoid the warning when building.

[t-nelson]

the warning is irrelevant. my question is whether the default feature were intentionally removed for these specifications and that if so, we are resolving the warning in the wrong direction. that is, these specifications should not be using the workspace dependency declaration, but their own with the subset of features required

[LucasSte]

the warning is irrelevant. my question is whether the default feature were intentionally removed for these specifications and that if so, we are resolving the warning in the wrong direction. that is, these specifications should not be using the workspace dependency declaration, but their own with the subset of features required

@joncinque and @kevinheavey Any thoughts on using a subset of features for these SDK crates?

[joncinque]

I agree with Trent here, this was done incorrectly. Rather than removing default-features = false from the individual crates dependency declarations, we should be adding default-features = false to the workspace declaration, like with

agave/Cargo.toml

Line 395 in 0cfcd47

solana-connection-cache = { path = "connection-cache", version = "=2.2.0", default-features = false }

[steviez]

I'll do the approach that was discussed by Trent & Jon. So, I'm going to back this commit out of master in #5153. This means we shouldn't BP this so closing this out