Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Remove deprecated helper function #4818

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

steviez
Copy link

@steviez steviez commented Feb 6, 2025

Summary of Changes

getConfirmedSignaturesForAddress was removed in v2.0. This changes removes get_confirmed_signatures_for_address(), which was a helper function for that RPC method. This was seemingly just missed in the commit that removed the deprecated functions

In #1809, we can see that the only caller of this function was removed. clippy probably just missed this function as unused due to pub:
https://github.com/anza-xyz/agave/pull/1809/files#diff-b55d9bcb5d2e7eae09fd352edcc765f9c2a4c05b97e9847582071d35850e8671L4735-L4762

getConfirmedSignaturesForAddress was removed in v2.0. This changes
removes get_confirmed_signatures_for_address(), which was a helper
function for that RPC method. This was seemingly just missed in the
commit that removed the deprecated functions
Copy link

mergify bot commented Feb 6, 2025

If this PR represents a change to the public RPC API:

  1. Make sure it includes a complementary update to rpc-client/ (example)
  2. Open a follow-up PR to update the JavaScript client @solana/web3.js (example)

Thank you for keeping the RPC clients in sync with the server API @steviez.

Copy link

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still a method in @solana/web3.js@1 but it no longer relies on calling this puppy. It emulates it.

https://github.com/solana-labs/solana-web3.js/blob/4e9988cfc561f3ed11f4c5016a29090a61d129a8/src/connection.ts#L5446-L5505

@steviez steviez merged commit 636d79f into anza-xyz:master Feb 6, 2025
66 checks passed
@steviez steviez deleted the rpc_cleanup_deprecated_function branch February 6, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants