-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update validator-failover.md #4689
base: master
Are you sure you want to change the base?
Conversation
I might be biased, but I think this change should be made. Nobody uses etcd and it's not recommended by anybody. We usually have to end up linking my gitbook document. Makes more sense to have this in the docs. |
I saw that this was attempted previously in #3683. However, that PR never moved out of As for the actual intent, it seems like most validator operators are using the newer approach over |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall a great change. I have some wording requests.
added # example script of the above steps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content in general looks look, just a couple formatting / grammatical nitpicks and then I'll think this will be good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
CI says you have a bunch of trailing whitespace; please remove that (typically as simple as a setting in your editor): |
i kicked out the old etcd method, as thats not recommended to use. etcd is not very reliable and this introduces a single point of failure that is not necessary.
Ive basically used pumpkins guide from here https://pumpkins-pool.gitbook.io/pumpkins-pool and updated the readme accordingly.