Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validator-failover.md #4689

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

schmiatz
Copy link

i kicked out the old etcd method, as thats not recommended to use. etcd is not very reliable and this introduces a single point of failure that is not necessary.
Ive basically used pumpkins guide from here https://pumpkins-pool.gitbook.io/pumpkins-pool and updated the readme accordingly.

@mergify mergify bot requested a review from a team January 29, 2025 18:14
@bartenbach
Copy link

I might be biased, but I think this change should be made.

Nobody uses etcd and it's not recommended by anybody. We usually have to end up linking my gitbook document. Makes more sense to have this in the docs.

@steviez
Copy link

steviez commented Jan 29, 2025

I saw that this was attempted previously in #3683. However, that PR never moved out of Draft state so it wasn't clear if it was ever ready.

As for the actual intent, it seems like most validator operators are using the newer approach over etcd. I can possibly take a look here, but I might see if @tigarcia is comfortable reviewing or if we can find someone else if not

@tigarcia tigarcia self-assigned this Feb 6, 2025
Copy link

@tigarcia tigarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a great change. I have some wording requests.

tigarcia
tigarcia previously approved these changes Mar 6, 2025
Copy link

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content in general looks look, just a couple formatting / grammatical nitpicks and then I'll think this will be good to go

@steviez steviez added the CI Pull Request is ready to enter CI label Mar 9, 2025
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Mar 9, 2025
Copy link

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@steviez steviez self-requested a review March 9, 2025 06:26
@steviez
Copy link

steviez commented Mar 9, 2025

CI says you have a bunch of trailing whitespace; please remove that (typically as simple as a setting in your editor):
https://buildkite.com/anza/agave/builds/20219#01957994-44b8-4e8c-8e3c-bb938e7f7068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants