-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.1: Reapply changes from reverted PR 3423 (backport of #4257) #4671
Conversation
* Extract client code in send_transaction_service into a new structure. This is the same as PR#3423 but with minimized API changes in STS. In order to be able to use new client code in the `SendTransactionService`, I need to wrap network-related code with the new structure ConnectionCacheClient. To to that I also had to move some auxiliary code into separate files. * reexport some structures in the send_transaction_service * move back all the displaced structs * modify one log message * Move back Config to threads * unpack config only in process_transactions * Use reference structure unpack in arg list (cherry picked from commit 4fe5092) # Conflicts: # svm/examples/Cargo.lock
Cherry-pick of 4fe5092 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Hm, cherry-picking seems to be fine but CI breaks with missing |
the problem is that the corresponding lock file was committed, but not the toml. delete the lock file |
who's sme for this? @lijunwangs @alessandrod ? |
@t-nelson Alessandro has approved. |
This PR adds back changes from PR 3423 but this time with less API changes which allows to simplify backport to 2.1.
Problem
In order to be able to use new client code in the
SendTransactionService
(see #3444), I need to wrap network-related code with the new structureConnectionCacheClient
.Summary of Changes
To extract network code into a new structure, I had to move some auxiliary code into separate files.
Beside of that, changes are pretty minimal and I deliberately haven't tried to optimize existing code to keep changes minimal. It just does almost exactly the same as the old one.
This is an automatic backport of pull request #4257 done by [Mergify](https://mergify.com).