v2.1: Use parameter struct for configuring QUIC streamer (backport of #3328) #3377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
refactor: Use parameter struct for configuring QUIC streamer (cherry picked from commit 6319db8)
alessandrod
approved these changes
Oct 30, 2024
|
Reason for wanting to backport: it's early in 2.1, this PR doesn't include any logic changes just bundles a bunch of arguments in a struct, and I'm planning to backport other quic changes so this helps me reduce conflicts. |
|
breaks a public interface with consumers. comments in master pr |
|
just to confirm, am I right that we decided to not backport this? |
|
v2.1 is nearly ready for mainnet-beta, so closing this as stale. Re-open if you think it deserves further consideration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Methods with too many complicated parameters and duplication of parameterizing the quic server.
Summary of Changes
Add a parameter struct to pass the QUIC server parameters.
Fixes #
This is an automatic backport of pull request #3328 done by [Mergify](https://mergify.com).