Refactor Bank EAH fetch method #2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steviez
force-pushed
the
eah_fetch_refactor
branch
from
55a9cae to
54f5d80
Compare
Shift the check for whether *this* bank should include the EAH inside the fetch function; will avoid code duplication later
steviez
force-pushed
the
eah_fetch_refactor
branch
from
54f5d80 to
07ddd83
Compare
brooksprumo
approved these changes
Aug 19, 2024
| @@ -5264,9 +5263,13 @@ impl Bank { | |||
| self.parent_slot() < stop_slot && self.slot() >= stop_slot | |||
| } | |||
|
|
|||
| /// If the epoch accounts hash should be included in this Bank, then fetch it. If the EAH | |||
| /// If the epoch accounts hash should be included in this Bank, then fetch it. If the EAH | |||
There was a problem hiding this comment.
I guess that change probably should have been left out, but there are more instances of single-space than double-space in the file. I prefer single-space but don't feel too strongly about it. I do feel more strongly about consistency tho, in which case updating to single-space here gets us closer to uniformity
Given how many times I had to rebase on tip of master + push in order to get CI through, decided to push
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
Shift the check for whether *this* bank should include the EAH inside the fetch function; will avoid code duplication later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Shift the logic for checking if the hash should be fetched for this Bank (slot) inside the fetch method