Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash-cache-tool: Prints capitalization and num accounts when diffing files #2462

Merged

Conversation

brooksprumo
Copy link

@brooksprumo brooksprumo commented Aug 6, 2024

Problem

The hash cache tool does not print the number of accounts nor capitalization when diffing files.

Summary of Changes

When extracting entries, also sum the lamports for capitalization. Then print out this info.

We'll be using this more when diffing the whole state too.

@brooksprumo brooksprumo self-assigned this Aug 6, 2024
@brooksprumo brooksprumo marked this pull request as ready for review August 6, 2024 17:55
@jeffwashington jeffwashington self-requested a review August 6, 2024 18:13
Copy link

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo added the automerge automerge Merge this Pull Request automatically once CI passes label Aug 6, 2024
@mergify mergify bot merged commit 44f6e03 into anza-xyz:master Aug 6, 2024
41 checks passed
@brooksprumo brooksprumo deleted the hash-cache-tool/capitalization branch August 6, 2024 19:08
Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants