Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.18: ci: ignore curve25519-dalek audit temporarily (backport of #1786) #1891

Closed
wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 27, 2024

Problem

audit failed
Screenshot 2024-06-19 at 11 12 26

I had a PR for this one weeks ago, but it's still stuck in the SPL downstream project test. I will prioritize this one. Ignore this audit to unblock CI.

#1693

Summary of Changes

ignore the audit temporarily


This is an automatic backport of pull request #1786 done by Mergify.

@mergify mergify bot requested a review from a team as a code owner June 27, 2024 01:56
@mergify mergify bot added the conflicts label Jun 27, 2024
@mergify mergify bot assigned yihau Jun 27, 2024
Copy link
Author

mergify bot commented Jun 27, 2024

Cherry-pick of a6bc917 has failed:

On branch mergify/bp/v1.18/pr-1786
Your branch is up to date with 'origin/v1.18'.

You are currently cherry-picking commit a6bc917f36.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ci/do-audit.sh

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@steviez
Copy link

steviez commented Jun 27, 2024

I know we ignored the audit on master because we expect to perform the suggested version bump soon; however, it is not immediately obvious to me if ignoring the issue is safe on our v1.18 branch. @ryoqun - You reviewed the initial PR, do you have any insights on this? If not, I can do digging through to try to figure out what the appropriate action is for the v1.18 branch

Copy link
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yihau and others added 2 commits July 1, 2024 09:37
ci: ignore curve25519-dalek audit
(cherry picked from commit a6bc917)

# Conflicts:
#	ci/do-audit.sh
@steviez steviez force-pushed the mergify/bp/v1.18/pr-1786 branch from cf1f38b to 1c6a846 Compare July 1, 2024 14:37
@steviez
Copy link

steviez commented Jul 2, 2024

Closing this PR - we ended up getting this as part of #1939

@steviez steviez closed this Jul 2, 2024
@mergify mergify bot deleted the mergify/bp/v1.18/pr-1786 branch July 2, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants