Notify panics in handlers to the scheduler thread promptly #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 2, 2024
ryoqun
force-pushed
the
graceful-abort-on-panic
branch
2 times, most recently
from
62520f2 to
5b09500
Compare
ryoqun
changed the title
|
oops, fixed the pr title... branch name is complete misnomer. I won't fix it... ;) |
ryoqun
changed the title
ryoqun
commented
Jun 2, 2024
Comment on lines
+1802
to
+1809
| let progress = sleepless_testing::setup(&[ | ||
| &TestCheckPoint::BeforeNewTask, | ||
| &CheckPoint::NewTask(0), | ||
| &PanickingHanlderCheckPoint::BeforeNotifiedPanic, | ||
| &CheckPoint::SchedulerThreadAborted, | ||
| &PanickingHanlderCheckPoint::BeforeIgnoredPanic, | ||
| &TestCheckPoint::BeforeEndSession, | ||
| ]); |
There was a problem hiding this comment.
I'm satisfied with sleepless_testing. :)
ryoqun
changed the title
ryoqun
force-pushed
the
graceful-abort-on-panic
branch
from
5b09500 to
0067ad6
Compare
apfitzge
reviewed
Jun 10, 2024
unified-scheduler-pool/src/lib.rs
Outdated
Comment on lines
1066
to
1068
| // It seems that scheduler has been aborted... | ||
| // This branch is deliberately tested by using 2 transactions with | ||
| // different timings in test_scheduler_schedule_execution_panic |
There was a problem hiding this comment.
nit: seems odd to me to comment how the code is tested in the code itself. test name could change, etc.
There was a problem hiding this comment.
hm, good point. done: d83571b
apfitzge
approved these changes
Jun 10, 2024
samkim-crypto
pushed a commit
to samkim-crypto/agave
that referenced
this pull request
Jul 31, 2024
…1574) * Gracefully abort scheduler on a panic in handlers * Move test-related mention out of the tested code itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
From #1211:
Summary of Changes
This pr addresses (2).