Removes the reserialize fns #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
force-pushed
the
reserde/remove/fns
branch
from
e5bcc44 to
1f1820a
Compare
brooksprumo
commented
May 30, 2024
| @@ -97,245 +92,6 @@ mod tests { | |||
| }) | |||
| } | |||
|
|
|||
| fn test_bank_serialize_style( | |||
There was a problem hiding this comment.
It is safe to remove this test because in the previous PR I added a new test directly below this one (test_serialize_bank_snapshot()) that covers the same usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We no longer reserialize bank snapshots. These functions are now unused and can be removed.
Summary of Changes
Remove 'em.
(And fix up tests that relied on them.)