Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-core subgem to release grpc dependencies #43

Closed
jjb opened this issue May 3, 2024 · 7 comments
Closed

-core subgem to release grpc dependencies #43

jjb opened this issue May 3, 2024 · 7 comments

Comments

@jjb
Copy link
Contributor

jjb commented May 3, 2024

when using anycable over http, one doesn't need grpc

https://docs.anycable.io/ruby/http_rpc?id=rpc-over-http

NOTE: If you don't use AnyCable gRPC server in any environment, you can avoid installing gRPC dependencies by using the anycable-rails-core gem instead of anycable-rails.

this isn't possible with graphql-anycable though, because it has a dependency on anycable

so, i think we need a -core subgem

or maybe just modify this one so that grpc needs to be manually added

@jjb jjb changed the title -core varriant to release grpc dependencies -core subgem to release grpc dependencies May 3, 2024
@jjb
Copy link
Contributor Author

jjb commented May 3, 2024

i have a version of my app working with this branch, with just the dependency name changed

master...jjb:graphql-anycable:patch-1

@palkan
Copy link
Member

palkan commented May 5, 2024

We don't need a subgem here, this gem should depend on anycable-core. @Envek will you be able to craft a new release?

@Envek
Copy link
Member

Envek commented May 7, 2024

Yep, will do a new release. Going to bump a minor version at least, as it feels to be a bit breaking change.

@Envek Envek closed this as completed in 39bb733 May 7, 2024
@Envek
Copy link
Member

Envek commented May 7, 2024

Released in 1.2.0

@jjb
Copy link
Contributor Author

jjb commented May 8, 2024

Thanks! However I can't use it because my system still requires client-provided channel identifiers 😅 any chance you could bring that back, and take it out in 2.0?

@Envek
Copy link
Member

Envek commented May 8, 2024

any chance you could bring that back, and take it out in 2.0?

Nope (too late)

Use 1.1.7 instead.

@jjb
Copy link
Contributor Author

jjb commented May 8, 2024

wow, a version just for me! 😄 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants