-
-
Notifications
You must be signed in to change notification settings - Fork 51.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Watermark): remove 'hidden' when append watermark, prevent hide … #52891
fix(Watermark): remove 'hidden' when append watermark, prevent hide … #52891
Conversation
…watermark by editing DOM attributes
|
👁 Visual Regression Report for PR #52891 Passed ✅
🎊 Congrats! No visual-regression diff found. ![]() |
WalkthroughThis pull request modifies the watermark component to remove the 'hidden' attribute when appending the watermark element. This change is intended to prevent the watermark from being hidden by editing DOM attributes, enhancing the robustness of the watermark feature. Changes
|
components/watermark/useWatermark.ts
Outdated
@@ -49,6 +49,7 @@ export default function useWatermark( | |||
); | |||
// Prevents using the browser `Hide Element` to hide watermarks | |||
watermarkEle.removeAttribute('class'); | |||
watermarkEle.removeAttribute('hidden') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that removing the 'hidden' attribute does not inadvertently expose any sensitive information or affect other functionalities that rely on this attribute.
Bundle ReportChanges will increase total bundle size by 8 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
|
More templates
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #52891 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 768 768
Lines 13844 13848 +4
Branches 3629 3629
=========================================
+ Hits 13844 13848 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: afc163 <afc163@gmail.com>
…watermark by editing DOM attributes
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
📝 Change Log