fix: fix style unit #52554

li-jia-nan · 2025-01-23T15:51:25Z

🤔 This is a ...

🔗 Related Issues

Describe the source of related requirements, such as links to relevant issue discussions.

For example: close #xxxx, fix #xxxx

💡 Background and Solution

feat: add underlined variant #52546

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://ant.design/changelog

Language	Changelog
🇺🇸 English	fix: fix style unit
🇨🇳 Chinese	fix: fix style unit

stackblitz · 2025-01-23T15:51:28Z

Run & review this pull request in StackBlitz Codeflow.

github-actions · 2025-01-23T15:51:37Z

github-actions · 2025-01-23T15:51:37Z

👁 Visual Regression Report for PR #52554 Failed ❌

🎯 Target branch: feature (cad00f1)
📖 View Full Report ↗︎
📊 Summary: 🔄 49 changed

Expected (Branch feature)	Actual (Current PR)	Diff
cascader-variant.compact.png	cascader-variant.compact.png
cascader-variant.compact.png	cascader-variant.compact.css-var.png
cascader-variant.dark.png	cascader-variant.dark.png
cascader-variant.dark.png	cascader-variant.dark.css-var.png
cascader-variant.default.png	cascader-variant.default.png
cascader-variant.default.png	cascader-variant.default.css-var.png
date-picker-variant.compact.png	date-picker-variant.compact.png
date-picker-variant.compact.png	date-picker-variant.compact.css-var.png

Warning

There are more diffs not shown in the table. Please check the Full Report for details.

Important

There are 49 diffs found in this PR: 🔄 49 changed.
Please check all items:

Checked all diffs in the full report
Visual diff is acceptable

petercat-assistant · 2025-01-23T15:51:41Z

Walkthrough

This pull request addresses a bug fix related to style units in the Ant Design project. The changes involve updating the borderWidth property to ensure that the unit function is applied to the lineWidth token, enhancing consistency and correctness in style definitions.

Changes

Files	Summary
components/input/style/variants.ts, components/select/style/variants.ts	Updated `borderWidth` to use `unit(token.lineWidth)` for consistent style unit application.

components/input/style/variants.ts

components/select/style/variants.ts

github-actions · 2025-01-23T15:54:03Z

size-limit report 📦

Path	Size
`dist/antd.min.js`	442.01 KB (-7 B 🔽)
`dist/antd-with-locales.min.js`	510.18 KB (-10 B 🔽)

pkg-pr-new · 2025-01-23T15:54:55Z

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52554

commit: d0b8839

codecov · 2025-01-23T15:55:06Z

Bundle Report

Changes will increase total bundle size by 24 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antd.min-array-push	3.38MB	24 bytes (0.0%) ⬆️

cloudflare-workers-and-pages · 2025-01-23T16:00:13Z

Deploying ant-design with Cloudflare Pages

Latest commit:	`d0b8839`
Status:	✅ Deploy successful!
Preview URL:	https://e7e2d5be.ant-design.pages.dev
Branch Preview URL:	https://fix-unit.ant-design.pages.dev

View logs

codecov · 2025-01-23T16:04:49Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cad00f1) to head (d0b8839).
Report is 1 commits behind head on feature.

Additional details and impacted files

@@            Coverage Diff            @@
##           feature    #52554   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          763       763           
  Lines        13802     13802           
  Branches      3611      3611           
=========================================
  Hits         13802     13802

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* chore: update rc-tooltip version to 6.4.0 in package.json (#52293) * chore: update rc-tooltip version to 6.4.0 in package.json * chore: trigger CI build * test: update snapshot * chore: trigger CI build * feat: add label classname for Checkbox & Radio (#52322) Co-authored-by: thinkasany <480968828@qq.com> * feat(ConfigProvider): support Modal centered global config (#52343) * chore: update snapshot * chore: update snapshot * fix(locale): update filterCheckall to filterCheckAll (#52517) * feat(locale): update filterCheckall to filterCheckAll Co-authored-by: ytahirkose <ytahirkose@gmail.com> * fix --------- Co-authored-by: ytahirkose <ytahirkose@gmail.com> * add underlined variant (#52546) * feat: add variant underlined in Input&&InputNumber&&Mentions Signed-off-by: 绍晗 <zhaoshaoting.zst@alibaba-inc.com> * fix: fix eslint Signed-off-by: 绍晗 <zhaoshaoting.zst@alibaba-inc.com> * fix: remove commented code Signed-off-by: 绍晗 <zhaoshaoting.zst@alibaba-inc.com> * fix: update underlined style Signed-off-by: 绍晗 <zhaoshaoting.zst@alibaba-inc.com> * fix:fix eslint problem Signed-off-by: 绍晗 <zhaoshaoting.zst@alibaba-inc.com> * feat: add Select variant underlined to #51379 * feat: add underlined demo to #51379 * feat: update snapshots to #51379 * feat: update doc to #51379 --------- Signed-off-by: 绍晗 <zhaoshaoting.zst@alibaba-inc.com> Co-authored-by: 绍晗 <zhaoshaoting.zst@alibaba-inc.com> * demo: update variant demo (#52547) * refactor: hooks of context (#52550) * feat: TooltipRef export popup element (#49230) * fix: fix cssinjs unit (#52554) * refactor: hooks of context (#52564) * refactor: hooks of context (#52575) * refactor: useComponentConfig for batch component (#52586) * refactor: hooks of context * refactor: hooks of context * feat: orientation prop support start & end (#52567) * feat: orientation support start & end * docs: update api docs * fix: update docs * test: update snap * test: update snap * test: update snap * fix: fix * fix: fix style * feat(Input): deprecate Input.Group (#52571) * refactor(Input): make TextArea style tree shakeable (#52570) * refactor(AutoComplete): tree shakeable (#52574) * refactor(App): split files (#52573) * refactor: remove enum, try to reduce the bundle size (#52557) * feat: Progress/Step supports round/floor/ceil for the current step calculate logic (#52017) * Support round/floor/ceil for the current step calculate logic Always `round` is not really good. In my case, I really want step current to be 2 when percent is 34% with 3 steps. Signed-off-by: Đào Văn Hùng <memsenpai3@gmail.com> * Update Steps.tsx Signed-off-by: Đào Văn Hùng <memsenpai3@gmail.com> * Update docs and props * refactor(Steps): rename stepRound to rounding and update type to function * fix(Steps): update rounding prop type to specify argument type * fix(Steps): update rounding prop type to specify parameter name * docs(Progress): add rounding function description to props table * fix(Steps): update rounding prop to use custom default function and document default value * fix(Progress): update rounding prop type to specify parameter name in documentation * fix(Steps): remove extra comma in default rounding prop assignment * Update components/progress/index.en-US.md Signed-off-by: lijianan <574980606@qq.com> * Update components/progress/index.zh-CN.md Signed-off-by: lijianan <574980606@qq.com> --------- Signed-off-by: Đào Văn Hùng <memsenpai3@gmail.com> Signed-off-by: lijianan <574980606@qq.com> Co-authored-by: lijianan <574980606@qq.com> * feat(Button): deprecate Button.Group, prefer Space.Compact (#52572) * feat(Button): deprecate Button.Group, prefer Space.Compact * test: update snap --------- Signed-off-by: afc163 <afc163@gmail.com> Co-authored-by: afc163 <afc163@gmail.com> Co-authored-by: thinkasany <480968828@qq.com> * refactor: hooks of context (#52587) * fix: TextArea style missing (#52597) * fix: Textarea style missing * fix: Textarea style missing with context * perf: optimize internal input tree shaking (#52594) * refactor(ColorHexInput): optimize bundle size * refactor(FilterSearch): optimize bundle size * refactor(Transfer): optimize bundle size * feat: ConfigProvider support variant for Card (#52552) * feat: ConfigProvider support bordered for Card Co-authored-by: xiaobebe <wyy.xb@qq.com> * Revert "feat: ConfigProvider support bordered for Card" This reverts commit f84573c. * use useVariant * docs * update * fix * add warning * fix --------- Co-authored-by: xiaobebe <wyy.xb@qq.com> * refactor(Avatar): file name match component name (#52593) * feat: Segmented supports `shape="round"` (#52685) * feat: Segmented supports `shape="round"` * Update components/segmented/index.tsx Signed-off-by: afc163 <afc163@gmail.com> * Update index.zh-CN.md Signed-off-by: afc163 <afc163@gmail.com> * Update index.en-US.md Signed-off-by: afc163 <afc163@gmail.com> --------- Signed-off-by: afc163 <afc163@gmail.com> * feat(Descriptions): add labelColor token (#52700) * feat: input.otp add separator api (#52668) * feature(component): Input.OPT added separator api * test: add tests for OTP component separator rendering cases * refactor: apply code review suggestions * refactor: hooks of context (#52713) --------- Signed-off-by: 绍晗 <zhaoshaoting.zst@alibaba-inc.com> Signed-off-by: Đào Văn Hùng <memsenpai3@gmail.com> Signed-off-by: lijianan <574980606@qq.com> Signed-off-by: afc163 <afc163@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jony J <1844749591@qq.com> Co-authored-by: 栗嘉男 <574980606@qq.com> Co-authored-by: Guo Yunhe <guoyunhe.gyh@alibaba-inc.com> Co-authored-by: thinkasany <480968828@qq.com> Co-authored-by: afc163 <afc163@gmail.com> Co-authored-by: ytahirkose <ytahirkose@gmail.com> Co-authored-by: ustcfury <94168407+ustcfury@users.noreply.github.com> Co-authored-by: 绍晗 <zhaoshaoting.zst@alibaba-inc.com> Co-authored-by: 二货爱吃白萝卜 <smith3816@gmail.com> Co-authored-by: nuintun <nuintun@gmail.com> Co-authored-by: Đào Văn Hùng <memsenpai3@gmail.com> Co-authored-by: Guo Yunhe <i@guoyunhe.me> Co-authored-by: xiaobebe <wyy.xb@qq.com> Co-authored-by: Haceral <48341368+HaceraI@users.noreply.github.com>

fix: fix style unit

d0b8839

petercat-assistant bot reviewed Jan 23, 2025

View reviewed changes

components/input/style/variants.ts Show resolved Hide resolved

petercat-assistant bot reviewed Jan 23, 2025

View reviewed changes

components/select/style/variants.ts Show resolved Hide resolved

yoyo837 approved these changes Jan 23, 2025

View reviewed changes

li-jia-nan merged commit 69b473f into feature Jan 23, 2025
50 checks passed

li-jia-nan deleted the fix-unit branch January 23, 2025 16:10

MadCcc mentioned this pull request Feb 10, 2025

chore: master merge feature #52724

Merged

16 tasks

MadCcc mentioned this pull request Feb 10, 2025

docs: changelog 5.24.0 #52734

Merged

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fix style unit #52554

fix: fix style unit #52554

li-jia-nan commented Jan 23, 2025 •

edited

Loading

stackblitz bot commented Jan 23, 2025

github-actions bot commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited by li-jia-nan

Loading

petercat-assistant bot commented Jan 23, 2025

github-actions bot commented Jan 23, 2025

pkg-pr-new bot commented Jan 23, 2025

codecov bot commented Jan 23, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 23, 2025

codecov bot commented Jan 23, 2025 •

edited

Loading

fix: fix style unit #52554

fix: fix style unit #52554

Conversation

li-jia-nan commented Jan 23, 2025 • edited Loading

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

stackblitz bot commented Jan 23, 2025

github-actions bot commented Jan 23, 2025 • edited Loading

github-actions bot commented Jan 23, 2025 • edited by li-jia-nan Loading

👁 Visual Regression Report for PR #52554 Failed ❌

petercat-assistant bot commented Jan 23, 2025

Walkthrough

Changes

github-actions bot commented Jan 23, 2025

size-limit report 📦

pkg-pr-new bot commented Jan 23, 2025

codecov bot commented Jan 23, 2025 • edited Loading

Bundle Report

cloudflare-workers-and-pages bot commented Jan 23, 2025

Deploying ant-design with Cloudflare Pages

codecov bot commented Jan 23, 2025 • edited Loading

Codecov Report

li-jia-nan commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited by li-jia-nan

Loading

codecov bot commented Jan 23, 2025 •

edited

Loading

codecov bot commented Jan 23, 2025 •

edited

Loading