-
-
Notifications
You must be signed in to change notification settings - Fork 51.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
type: up React.MutableRefObject to React.Ref #52205
Conversation
|
👁 Visual Regression Report for PR #52205 Failed ❌
Important There are 1 diffs found in this PR: 🔄 1 changed.
|
WalkthroughThis pull request updates the TypeScript definitions by changing the type of the Changes
|
@@ -119,7 +119,7 @@ export interface InternalTableProps<RecordType = AnyObject> extends TableProps<R | |||
|
|||
const InternalTable = <RecordType extends AnyObject = AnyObject>( | |||
props: InternalTableProps<RecordType>, | |||
ref: React.MutableRefObject<HTMLDivElement>, | |||
ref: React.Ref<HTMLDivElement>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change from React.MutableRefObject<HTMLDivElement>
to React.Ref<HTMLDivElement>
is generally safe, but ensure that the component using this ref handles the possibility of the ref being null
, as React.Ref
can be null
when not assigned.
size-limit report 📦
|
More templates
commit: |
Deploying ant-design with
|
Latest commit: |
4ce1676
|
Status: | ✅ Deploy successful! |
Preview URL: | https://736f4d49.ant-design.pages.dev |
Branch Preview URL: | https://ref-type-up.ant-design.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #52205 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 763 763
Lines 13643 13643
Branches 3560 3560
=========================================
Hits 13643 13643 ☔ View full report in Codecov by Sentry. |
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
📝 Change Log